Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes gh-697 Enhance SqsAutoConfiguration to use an available ObjectMapper #906

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Fixes gh-697 Enhance SqsAutoConfiguration to use an available ObjectMapper #906

merged 1 commit into from
Oct 10, 2023

Conversation

postalservice14
Copy link
Contributor

@postalservice14 postalservice14 commented Oct 5, 2023 •
edited
Loading

Improves upon #845

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

See #697
See Original PR: #845

💡 Motivation and Context

See #697

💚 How did you test it?

Add unit tests

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • I updated reference documentation to reflect the change
  • All tests passing
  • No breaking changes

🔮 Next steps

@github-actions github-actions bot added the component: sqs SQS integration related issue label Oct 5, 2023
@postalservice14 postalservice14 mentioned this pull request Oct 5, 2023
Closed
9 tasks
tomazfernandes
tomazfernandes approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@tomazfernandes tomazfernandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @postalservice14, thanks, looking forward for more!

@tomazfernandes tomazfernandes merged commit d6d9dce into awspring:main Oct 10, 2023
4 checks passed
@tomazfernandes tomazfernandes mentioned this pull request Jan 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomazfernandes tomazfernandes tomazfernandes approved these changes

@maciejwalkowiak maciejwalkowiak Awaiting requested review from maciejwalkowiak maciejwalkowiak is a code owner

@MatejNedic MatejNedic Awaiting requested review from MatejNedic MatejNedic is a code owner

Assignees
No one assigned
Labels
component: sqs SQS integration related issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@postalservice14 @tomazfernandes