Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: S3 file listing if the prefix resolves to slash #912

Merged
merged 1 commit into from
Oct 23, 2023
Merged

fix: S3 file listing if the prefix resolves to slash #912

merged 1 commit into from
Oct 23, 2023

Conversation

klopfdreh
Copy link
Contributor

@klopfdreh klopfdreh commented Oct 16, 2023 •
edited
Loading

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

See Motivation and Context

💡 Motivation and Context

fixes: #900

💚 How did you test it?

By using the implementation against a S3 bucket. see Motivation and Context

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • I updated reference documentation to reflect the change
  • All tests passing
  • No breaking changes

🔮 Next steps

@github-actions github-actions bot added the component: s3 S3 integration related issue label Oct 16, 2023
@maciejwalkowiak maciejwalkowiak added this to the 3.0.3 milestone Oct 23, 2023
@maciejwalkowiak maciejwalkowiak added the type: bug Something isn't working label Oct 23, 2023
@maciejwalkowiak
Copy link
Contributor

Thanks @klopfdreh

@maciejwalkowiak maciejwalkowiak merged commit 53926a0 into awspring:main Oct 23, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maciejwalkowiak maciejwalkowiak maciejwalkowiak approved these changes

@MatejNedic MatejNedic Awaiting requested review from MatejNedic MatejNedic is a code owner

@tomazfernandes tomazfernandes Awaiting requested review from tomazfernandes tomazfernandes is a code owner

Assignees
No one assigned
Labels
component: s3 S3 integration related issue type: bug Something isn't working
Projects
None yet
Milestone
3.0.3
Development

Successfully merging this pull request may close these issues.

S3 file listing is not working if the prefix resolves to slash
2 participants
@klopfdreh @maciejwalkowiak