feat: starknet GMP #731
Open
feat: starknet GMP #731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjcobb23
reviewed
Jan 14, 2025
…couldn't deserialise the key
cjcobb23
reviewed
Jan 29, 2025
cjcobb23
reviewed
Jan 29, 2025
cjcobb23
reviewed
Jan 29, 2025
cjcobb23
reviewed
Jan 29, 2025
…fier set (#58) * take into account index on checking for events in verify verifier set * remove useless tuple with felt and event; now its only event * fix functions name for verifier set and verify contract call * return None on verify verifier set, if something went wrong / remove result and some errors that applied to prev scenario * simplify logic of verify verifier set
cjcobb23
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR consists of:
Todos
Steps to Test
You would need the Starknet relayer, in order to manually test, which is not open sourced or deployed yet.
Also we don't have integration or end-to-end tests yet.
Expected Behaviour
Handle GMP messages from other amplifier chains
Other Notes
The FieldElementAndEventIndex PR must be merged to main before this PR manages to compile successfully.