Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(minor-interchain-token-service): update chain config #757

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

cjcobb23
Copy link
Contributor

@cjcobb23 cjcobb23 commented Feb 6, 2025

Description

Add the ability to update chain config after initial registration

https://axelarnetwork.atlassian.net/browse/AXE-7356

Todos

  • Unit tests
  • Manual tests
  • Documentation
  • Connect epics/issues

Convention Checklist

  • Each contract should have a client mod for others to interact with it.
  • Derive macros
  • The state mod and msg mod should use separate data structures so that internal state changes do not break the contract interface. Check out the interchain-token-service for reference.
    • msg.rs should never use any type from the state.rs
    • Shared types must be defined in a separate exported mod. If those types have already been defined somewhere else, then they should get re-exported in the exported mod

Steps to Test

Expected Behaviour

Notes

@cjcobb23 cjcobb23 requested a review from a team as a code owner February 6, 2025 21:49
Copy link

codecov bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.68%. Comparing base (541aad9) to head (b3d9c74).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #757      +/-   ##
==========================================
+ Coverage   93.65%   93.68%   +0.02%     
==========================================
  Files         222      222              
  Lines       36332    36471     +139     
==========================================
+ Hits        34028    34167     +139     
  Misses       2304     2304              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment on lines +394 to +398
chains
.into_iter()
.map(|chain_config| update_chain(deps.storage, chain_config))
.try_collect::<_, Vec<Response>, _>()?
.then(|_| Ok(Response::new()))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use try_for_each instead. You're not really interested in the returned object unless it's an error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants