refactor(interchain-token-service): use contractstorage #246
Conversation
| env.storage().persistent().set(&key, &()); | ||
| storage::set_trusted_chain_status(env, chain.clone()); |
There was a problem hiding this comment.
To clear state, similar to Operators: https://axelarnetwork.atlassian.net/browse/AXE-7428
There was a problem hiding this comment.
why is it needed here? The value is () here instead of a bool
There was a problem hiding this comment.
Not sure I understand– TrustChain is a status
nbayindirli
force-pushed
the
refactor/its-storage
branch
from
8046b93 to
9df5d88
Compare
|
|
||
| #[temporary] | ||
| #[value(i128)] | ||
| FlowIn { flow_key: FlowKey }, |
There was a problem hiding this comment.
remove the need for a wrapper key similar to message approval key
There was a problem hiding this comment.
Captured here: https://axelarnetwork.atlassian.net/browse/AXE-7358
| #[value(BytesN<32>)] | ||
| TokenManagerWasmHash, | ||
|
|
||
| #[persistent] |
There was a problem hiding this comment.
should look into making this instance type. We have to see if it can fit within the instance storage limits (e.g. can we trust 10k chains and still be under the limit). If the gas cost impact isn't significant, it's not needed
| env.storage().persistent().set(&key, &()); | ||
| storage::set_trusted_chain_status(env, chain.clone()); |
There was a problem hiding this comment.
why is it needed here? The value is () here instead of a bool
nbayindirli
force-pushed
the
refactor/its-storage
branch
from
9df5d88 to
5c0d1ac
Compare
nbayindirli
changed the base branch from
main
to
refactor/interchain-token-storage
AXE-7345