[feat] Make selector compression optional #15
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following:
keygen_vk_custom
function where user can choose whether to turn on selector compression(=combination) or not.halo2-axiom
,keygen_vk
will be set so the default is no selector compression.VerifyingKey
does not need to store anything about selectors. Afterkeygen_vk_custom
, theConstraintSystem
has entirely replaced selectors with fixed columns, and fixed commitments have been updated. Theverify_proof
function does not use selectors in any way. Inkeygen_pk
you still need to know about selectors, but it reconstructs theConstraintSystem
from scratch anyways.VerifyingKey::read
andwrite
functions accordingly, where there is now a new byte recording whether selector compression is on or off. When off, I skip serializing selectors since they are unnecessary for reasons mentioned above.