Update ingest methods to use edge regions #460
+100
−54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronoc
reviewed
Nov 3, 2025
send-data/heroku-log-drains.mdx
Outdated
|
|
||
| ```bash | ||
| heroku drains:add https://axiom:API_TOKEN@AXIOM_DOMAIN/v1/datasets/DATASET_NAME/ingest -a HEROKU_APPLICATION_NAME | ||
| heroku drains:add https://axiom:API_TOKEN@AXIOM_DOMAIN/v1/ingest/{AXIOM_DATASET} -a HEROKU_APPLICATION_NAME |
Member
There was a problem hiding this comment.
hmm good point, do we still support this ...
Collaborator
There was a problem hiding this comment.
I think for the sake of this PR, updating the endpoint is fine. I'll check later on about Heroku support.
manototh
reviewed
Nov 5, 2025
Co-authored-by: Mano Toth <71388581+manototh@users.noreply.github.com>
Co-authored-by: Mano Toth <71388581+manototh@users.noreply.github.com>
manototh
approved these changes
Nov 5, 2025
manototh
reviewed
Nov 10, 2025
| 'apiToken' => env('AXIOM_API_TOKEN'), | ||
| 'dataset' => env('AXIOM_DATASET'), | ||
| 'axiomUrl' => env('AXIOM_URL'), | ||
| 'region' => env('AXIOM_REGION', 'us-east-1.aws'), |
Collaborator
There was a problem hiding this comment.
I'm a bit confused about these changes. Could you please check if these are correct?
send-data/heroku-log-drains.mdx
Outdated
|
|
||
| ```bash | ||
| heroku drains:add https://axiom:API_TOKEN@AXIOM_DOMAIN/v1/datasets/DATASET_NAME/ingest -a HEROKU_APPLICATION_NAME | ||
| heroku drains:add https://axiom:API_TOKEN@AXIOM_DOMAIN/v1/ingest/{AXIOM_DATASET} -a HEROKU_APPLICATION_NAME |
Collaborator
There was a problem hiding this comment.
I think for the sake of this PR, updating the endpoint is fine. I'll check later on about Heroku support.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.