Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] ILP Conv Layer support #38

Merged
merged 6 commits into from
Oct 24, 2023
Merged

[WIP] ILP Conv Layer support #38

merged 6 commits into from
Oct 24, 2023

Conversation

prajwal1210
Copy link
Contributor

@prajwal1210 prajwal1210 commented Oct 10, 2023 •
edited
Loading

Tests:

  • Compared loss curves with 1 GPU and 2x2 GPUs
  • Added CI tests and checked using that

@prajwal1210 prajwal1210 changed the title ILP Conv Layer support [WIP] ILP Conv Layer support Oct 10, 2023
@siddharth9820 siddharth9820 self-requested a review October 10, 2023 18:08
@siddharth9820 siddharth9820 added the WIP Work in progress label Oct 10, 2023
@siddharth9820
Copy link
Collaborator

Can you post the loss curves here too?

@prajwal1210
Copy link
Contributor Author

Can you post the loss curves here too?

EpochLossComparison
IterLossComparison

@siddharth9820 siddharth9820 added this to the v0.2.0 milestone Oct 18, 2023
siddharth9820
siddharth9820 approved these changes Oct 24, 2023
View reviewed changes
Copy link
Collaborator

@siddharth9820 siddharth9820 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@siddharth9820 siddharth9820 merged commit d69dbb9 into develop Oct 24, 2023
6 checks passed
@siddharth9820 siddharth9820 deleted the convlayer branch October 24, 2023 16:38
Avuxon pushed a commit that referenced this pull request Jan 25, 2024
@prajwal1210 @siddharth9820
[WIP] ILP Conv Layer support (#38)
c1694b1 
* ILP Conv Layer support

---------

Co-authored-by: Siddharth Singh <siddharth9820@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siddharth9820 siddharth9820 siddharth9820 approved these changes

@bhatele bhatele Awaiting requested review from bhatele

Assignees
No one assigned
Labels
WIP Work in progress
Projects
None yet
Milestone
v0.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@prajwal1210 @siddharth9820