Expand tilde in SSL certificate paths #73
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add expandPath helper function to expand ~ to the user's home directory when loading SSL certificates. This fixes the issue where relative paths like ~/.cassandra/cqlsh.crt were not being found because the tilde was not expanded to the actual home directory path. Fixes #72
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
The G304 warning is suppressed because the CA certificate path comes from trusted user configuration, not untrusted input.
rgooding
reviewed
Feb 9, 2026
internal/db/db.go
Outdated
|
|
||
| // expandPath expands ~ to the user's home directory | ||
| func expandPath(path string) string { | ||
| if strings.HasPrefix(path, "~") { |
There was a problem hiding this comment.
For safety is it maybe worth checking that the path starts with ~/ rather than just ~?
rgooding
approved these changes
Feb 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
expandPathhelper function that expands~to the user's home directoryCertPath,KeyPath, andCAPathbefore loading SSL certificates$HOMEenvironment variable with fallback toos.UserHomeDir()for robustnessTest plan
~(e.g.,~/.cassandra/cqlsh.crt)$HOMEis not set (usesos.UserHomeDir()fallback)Fixes #72