Add -Werror compiler option and fix existing warnings

axothy · Oct 5, 2023 · 47d31c7 · 47d31c7
1 parent f5e4947
commit 47d31c7
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/build.gradle b/build.gradle
@@ -13,6 +13,7 @@ java {
 repositories {
     mavenCentral()
 }
+
 dependencies {
     // Checks
     errorprone 'com.google.errorprone:error_prone_core:2.11.0'
@@ -37,9 +38,11 @@ checkstyle {
 
 compileJava {
     options.compilerArgs += ["--enable-preview"]
+
+    // Enforce errors
+    options.compilerArgs += ["-Werror"]
 }
 
 compileTestJava {
     options.compilerArgs += ["--enable-preview"]
 }
-
diff --git a/src/main/java/ru/vk/itmo/boturkhonovkamron/MemorySegmentComparator.java b/src/main/java/ru/vk/itmo/boturkhonovkamron/MemorySegmentComparator.java
@@ -27,6 +27,6 @@ public int compare(final MemorySegment left, final MemorySegment right) {
             return Byte.compare(left.get(ValueLayout.JAVA_BYTE, mismatch),
                     right.get(ValueLayout.JAVA_BYTE, mismatch));
         }
-        return (int) (leftSize - rightSize);
+        return Long.compare(leftSize, rightSize);
     }
 }
diff --git a/src/main/java/ru/vk/itmo/test/tuzikovalexandr/DaoFactoryImpl.java b/src/main/java/ru/vk/itmo/test/tuzikovalexandr/DaoFactoryImpl.java
@@ -22,7 +22,7 @@ public String toString(MemorySegment memorySegment) {
 
         ByteBuffer byteBuffer = memorySegment.asByteBuffer();
 
-        return byteBuffer == null ? null : new String(byteBuffer.array(), StandardCharsets.UTF_8);
+        return byteBuffer == null ? null : new String(byteBuffer.array(), byteBuffer.arrayOffset(), byteBuffer.remaining(), StandardCharsets.UTF_8);
     }
 
     @Override