fix connection memory leak, release beta 1.6

ayakashi-io · May 11, 2019 · 7be5d84 · 7be5d84
1 parent 2e93216
commit 7be5d84
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/npm-shrinkwrap.json b/npm-shrinkwrap.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "ayakashi",
-  "version": "1.0.0-beta1.5",
+  "version": "1.0.0-beta1.6",
   "description": "The next generation web scraping framework",
   "author": {
     "name": "ayakashi.io",
@@ -102,7 +102,7 @@
     "build": "tsc --build --clean && tsc --build",
     "watch": "tsc --build --clean && tsc --watch",
     "test": "npm run build && node lib/cli/cli.js get-chrome ./__tests__ && jest --forceExit",
-    "build-types": "tsc --build --clean && tsc -d --emitDeclarationOnly --allowJs false",
+    "build-types": "rm -rf ./lib && tsc --build --clean && tsc -d --emitDeclarationOnly --allowJs false",
     "generate-core-action-docs": "typedoc --mode file --json ./doc.json && node ./scripts/generateCoreActionDocs.js && rm ./doc.json",
     "postinstall": "node scripts/postInstall.js",
     "prepublishOnly": "rm -rf ./lib && tsc --build --clean && tsc --build && npm shrinkwrap"

diff --git a/src/engine/createConnection.ts b/src/engine/createConnection.ts
@@ -249,6 +249,7 @@ export async function createConnection(
                     await connection.client.Page.stopLoading();
                     await connection.client.Page.navigate({url: "about:blank"});
                     await connection.client.Page.domContentEventFired();
+                    await client.close();
                     connection.active = false;
                     await request.post(`http://localhost:${bridgePort}/connection_released`, {
                         json: {