Add new HTML Tag Editor #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TagEdit is new HTML Tag Editor as a TipTap extension.
takahashim
force-pushed
the
use-tag-edit
branch
from
5cfcb02 to
f178a58
Compare
ayuki-joto
merged commit a4e1d25
into
ayuki-joto:feat/update-decidim-0-28-0
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Decidim v0.28でHTMLタグエディタが動かなくなっていたので、TipTap用に新しく作り直したTagEditに差し替えます。
TagEditはvideoEmbedを参考にしています。videoEmbedは
InputDialogという拡張を使っていますが、これをtextarea用に修正したTextDialogというライブラリを追加してダイアログ表示に使用しています。📌 Related Issues
📋 Subtasks
CHANGELOGupgrade notes, if required📷 Screenshots (optional)