Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make emitUpdate true in setContent to enable immediate changes #44

Merged

Conversation

takahashim
Copy link
Collaborator

🎩 What? Why?

HTMLタグエディタでコンテンツを修正した際、その後にWYSIWYGエディタを使わずにすぐに編集完了しようすると修正が反映されないようでした。
その問題を修正するPRです。

📌 Related Issues

  • Related to #?
  • Fixes #?

📋 Subtasks

  • Add CHANGELOG upgrade notes, if required
  • If there's a new public field, add it to GraphQL API
  • Add documentation regarding the feature
  • Add/modify seeds
  • Add tests
  • Another subtask

@takahashim
Copy link
Collaborator Author

メモ:具体的にはsetContentの第2引数emitUpdateをtrueにしています。
こうするとupdateイベントをtriggerするようでした。
https://tiptap.dev/docs/editor/api/commands/content/set-content

@ayuki-joto ayuki-joto merged commit 45c44c6 into ayuki-joto:feat/update-decidim-0-28-0 Dec 28, 2024
2 checks passed
@takahashim takahashim deleted the fix-setContent branch December 28, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants