fix ClientboundLevelParticlesPacket errors and pathfinder /particle e… #1886
Annotations
28 warnings
this bound is already specified as the supertrait of `Goal`:
azalea/src/pathfinder/mod.rs#L182
warning: this bound is already specified as the supertrait of `Goal`
--> azalea/src/pathfinder/mod.rs:182:60
|
182 | fn goto_without_mining(&self, goal: impl Goal + Send + Sync + 'static) {
| ^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implied_bounds_in_impls
help: try removing this bound
|
182 - fn goto_without_mining(&self, goal: impl Goal + Send + Sync + 'static) {
182 + fn goto_without_mining(&self, goal: impl Goal + Send + 'static) {
|
|
this bound is already specified as the supertrait of `Goal`:
azalea/src/pathfinder/mod.rs#L182
warning: this bound is already specified as the supertrait of `Goal`
--> azalea/src/pathfinder/mod.rs:182:53
|
182 | fn goto_without_mining(&self, goal: impl Goal + Send + Sync + 'static) {
| ^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implied_bounds_in_impls
help: try removing this bound
|
182 - fn goto_without_mining(&self, goal: impl Goal + Send + Sync + 'static) {
182 + fn goto_without_mining(&self, goal: impl Goal + Sync + 'static) {
|
|
this bound is already specified as the supertrait of `Goal`:
azalea/src/pathfinder/mod.rs#L171
warning: this bound is already specified as the supertrait of `Goal`
--> azalea/src/pathfinder/mod.rs:171:45
|
171 | fn goto(&self, goal: impl Goal + Send + Sync + 'static) {
| ^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implied_bounds_in_impls
help: try removing this bound
|
171 - fn goto(&self, goal: impl Goal + Send + Sync + 'static) {
171 + fn goto(&self, goal: impl Goal + Send + 'static) {
|
|
this bound is already specified as the supertrait of `Goal`:
azalea/src/pathfinder/mod.rs#L171
warning: this bound is already specified as the supertrait of `Goal`
--> azalea/src/pathfinder/mod.rs:171:38
|
171 | fn goto(&self, goal: impl Goal + Send + Sync + 'static) {
| ^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implied_bounds_in_impls
help: try removing this bound
|
171 - fn goto(&self, goal: impl Goal + Send + Sync + 'static) {
171 + fn goto(&self, goal: impl Goal + Sync + 'static) {
|
|
this bound is already specified as the supertrait of `Goal`:
azalea/src/pathfinder/mod.rs#L104
warning: this bound is already specified as the supertrait of `Goal`
--> azalea/src/pathfinder/mod.rs:104:60
|
104 | fn goto_without_mining(&self, goal: impl Goal + Send + Sync + 'static);
| ^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implied_bounds_in_impls
help: try removing this bound
|
104 - fn goto_without_mining(&self, goal: impl Goal + Send + Sync + 'static);
104 + fn goto_without_mining(&self, goal: impl Goal + Send + 'static);
|
|
this bound is already specified as the supertrait of `Goal`:
azalea/src/pathfinder/mod.rs#L104
warning: this bound is already specified as the supertrait of `Goal`
--> azalea/src/pathfinder/mod.rs:104:53
|
104 | fn goto_without_mining(&self, goal: impl Goal + Send + Sync + 'static);
| ^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implied_bounds_in_impls
help: try removing this bound
|
104 - fn goto_without_mining(&self, goal: impl Goal + Send + Sync + 'static);
104 + fn goto_without_mining(&self, goal: impl Goal + Sync + 'static);
|
|
this bound is already specified as the supertrait of `Goal`:
azalea/src/pathfinder/mod.rs#L103
warning: this bound is already specified as the supertrait of `Goal`
--> azalea/src/pathfinder/mod.rs:103:45
|
103 | fn goto(&self, goal: impl Goal + Send + Sync + 'static);
| ^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implied_bounds_in_impls
help: try removing this bound
|
103 - fn goto(&self, goal: impl Goal + Send + Sync + 'static);
103 + fn goto(&self, goal: impl Goal + Send + 'static);
|
|
this bound is already specified as the supertrait of `Goal`:
azalea/src/pathfinder/mod.rs#L103
warning: this bound is already specified as the supertrait of `Goal`
--> azalea/src/pathfinder/mod.rs:103:38
|
103 | fn goto(&self, goal: impl Goal + Send + Sync + 'static);
| ^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implied_bounds_in_impls
= note: `#[warn(clippy::implied_bounds_in_impls)]` on by default
help: try removing this bound
|
103 - fn goto(&self, goal: impl Goal + Send + Sync + 'static);
103 + fn goto(&self, goal: impl Goal + Sync + 'static);
|
|
this `if` statement can be collapsed:
azalea/src/pathfinder/extras/process/mine_forever.rs#L47
warning: this `if` statement can be collapsed
--> azalea/src/pathfinder/extras/process/mine_forever.rs:47:5
|
47 | / if !pathfinder.is_calculating {
48 | | if !**items_to_pickup_change_acknowledged {
49 | | should_force_recalculate_path = true;
50 | | **items_to_pickup_change_acknowledged = true;
51 | | println!("items_to_pickup_change_acknowledged = true");
52 | | }
53 | | }
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
= note: `#[warn(clippy::collapsible_if)]` on by default
help: collapse nested if block
|
47 ~ if !pathfinder.is_calculating && !**items_to_pickup_change_acknowledged {
48 + should_force_recalculate_path = true;
49 + **items_to_pickup_change_acknowledged = true;
50 + println!("items_to_pickup_change_acknowledged = true");
51 + }
|
|
the borrowed expression implements the required traits:
azalea-physics/src/collision/shape.rs#L414
warning: the borrowed expression implements the required traits
--> azalea-physics/src/collision/shape.rs:414:47
|
414 | binary_search(0, upper_limit, &|t| coord < self.get(axis, t as usize)) - 1
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `|t| coord < self.get(axis, t as usize)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
= note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
|
unneeded `return` statement:
azalea/build.rs#L10
warning: unneeded `return` statement
--> azalea/build.rs:10:18
|
10 | Ok(_) => return, // nightly
| ^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
= note: `#[warn(clippy::needless_return)]` on by default
help: replace `return` with a unit value
|
10 | Ok(_) => (), // nightly
| ~~
|
this bound is already specified as the supertrait of `Goal`:
azalea/src/pathfinder/mod.rs#L182
warning: this bound is already specified as the supertrait of `Goal`
--> azalea/src/pathfinder/mod.rs:182:60
|
182 | fn goto_without_mining(&self, goal: impl Goal + Send + Sync + 'static) {
| ^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implied_bounds_in_impls
help: try removing this bound
|
182 - fn goto_without_mining(&self, goal: impl Goal + Send + Sync + 'static) {
182 + fn goto_without_mining(&self, goal: impl Goal + Send + 'static) {
|
|
this bound is already specified as the supertrait of `Goal`:
azalea/src/pathfinder/mod.rs#L182
warning: this bound is already specified as the supertrait of `Goal`
--> azalea/src/pathfinder/mod.rs:182:53
|
182 | fn goto_without_mining(&self, goal: impl Goal + Send + Sync + 'static) {
| ^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implied_bounds_in_impls
help: try removing this bound
|
182 - fn goto_without_mining(&self, goal: impl Goal + Send + Sync + 'static) {
182 + fn goto_without_mining(&self, goal: impl Goal + Sync + 'static) {
|
|
this bound is already specified as the supertrait of `Goal`:
azalea/src/pathfinder/mod.rs#L171
warning: this bound is already specified as the supertrait of `Goal`
--> azalea/src/pathfinder/mod.rs:171:45
|
171 | fn goto(&self, goal: impl Goal + Send + Sync + 'static) {
| ^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implied_bounds_in_impls
help: try removing this bound
|
171 - fn goto(&self, goal: impl Goal + Send + Sync + 'static) {
171 + fn goto(&self, goal: impl Goal + Send + 'static) {
|
|
this bound is already specified as the supertrait of `Goal`:
azalea/src/pathfinder/mod.rs#L171
warning: this bound is already specified as the supertrait of `Goal`
--> azalea/src/pathfinder/mod.rs:171:38
|
171 | fn goto(&self, goal: impl Goal + Send + Sync + 'static) {
| ^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implied_bounds_in_impls
help: try removing this bound
|
171 - fn goto(&self, goal: impl Goal + Send + Sync + 'static) {
171 + fn goto(&self, goal: impl Goal + Sync + 'static) {
|
|
this bound is already specified as the supertrait of `Goal`:
azalea/src/pathfinder/mod.rs#L104
warning: this bound is already specified as the supertrait of `Goal`
--> azalea/src/pathfinder/mod.rs:104:60
|
104 | fn goto_without_mining(&self, goal: impl Goal + Send + Sync + 'static);
| ^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implied_bounds_in_impls
help: try removing this bound
|
104 - fn goto_without_mining(&self, goal: impl Goal + Send + Sync + 'static);
104 + fn goto_without_mining(&self, goal: impl Goal + Send + 'static);
|
|
this bound is already specified as the supertrait of `Goal`:
azalea/src/pathfinder/mod.rs#L104
warning: this bound is already specified as the supertrait of `Goal`
--> azalea/src/pathfinder/mod.rs:104:53
|
104 | fn goto_without_mining(&self, goal: impl Goal + Send + Sync + 'static);
| ^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implied_bounds_in_impls
help: try removing this bound
|
104 - fn goto_without_mining(&self, goal: impl Goal + Send + Sync + 'static);
104 + fn goto_without_mining(&self, goal: impl Goal + Sync + 'static);
|
|
this bound is already specified as the supertrait of `Goal`:
azalea/src/pathfinder/mod.rs#L103
warning: this bound is already specified as the supertrait of `Goal`
--> azalea/src/pathfinder/mod.rs:103:45
|
103 | fn goto(&self, goal: impl Goal + Send + Sync + 'static);
| ^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implied_bounds_in_impls
help: try removing this bound
|
103 - fn goto(&self, goal: impl Goal + Send + Sync + 'static);
103 + fn goto(&self, goal: impl Goal + Send + 'static);
|
|
this bound is already specified as the supertrait of `Goal`:
azalea/src/pathfinder/mod.rs#L103
warning: this bound is already specified as the supertrait of `Goal`
--> azalea/src/pathfinder/mod.rs:103:38
|
103 | fn goto(&self, goal: impl Goal + Send + Sync + 'static);
| ^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implied_bounds_in_impls
= note: `#[warn(clippy::implied_bounds_in_impls)]` on by default
help: try removing this bound
|
103 - fn goto(&self, goal: impl Goal + Send + Sync + 'static);
103 + fn goto(&self, goal: impl Goal + Sync + 'static);
|
|
this `if` statement can be collapsed:
azalea/src/pathfinder/extras/process/mine_forever.rs#L47
warning: this `if` statement can be collapsed
--> azalea/src/pathfinder/extras/process/mine_forever.rs:47:5
|
47 | / if !pathfinder.is_calculating {
48 | | if !**items_to_pickup_change_acknowledged {
49 | | should_force_recalculate_path = true;
50 | | **items_to_pickup_change_acknowledged = true;
51 | | println!("items_to_pickup_change_acknowledged = true");
52 | | }
53 | | }
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
= note: `#[warn(clippy::collapsible_if)]` on by default
help: collapse nested if block
|
47 ~ if !pathfinder.is_calculating && !**items_to_pickup_change_acknowledged {
48 + should_force_recalculate_path = true;
49 + **items_to_pickup_change_acknowledged = true;
50 + println!("items_to_pickup_change_acknowledged = true");
51 + }
|
|
the borrowed expression implements the required traits:
azalea-physics/src/collision/shape.rs#L414
warning: the borrowed expression implements the required traits
--> azalea-physics/src/collision/shape.rs:414:47
|
414 | binary_search(0, upper_limit, &|t| coord < self.get(axis, t as usize)) - 1
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `|t| coord < self.get(axis, t as usize)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
= note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
|
unneeded `return` statement:
azalea/build.rs#L10
warning: unneeded `return` statement
--> azalea/build.rs:10:18
|
10 | Ok(_) => return, // nightly
| ^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
= note: `#[warn(clippy::needless_return)]` on by default
help: replace `return` with a unit value
|
10 | Ok(_) => (), // nightly
| ~~
|
clippy_check
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
clippy_check
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/cache@v3, actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
clippy_check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
clippy_check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
clippy_check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
clippy_check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|