add 1.21.1 to branches list in readme #1935
Annotations
15 warnings
empty line after doc comment:
azalea/src/swarm/mod.rs#L550
warning: empty line after doc comment
--> azalea/src/swarm/mod.rs:550:1
|
550 | / /// }
551 | |
| |_
552 | impl Swarm {
| ---------- the comment documents this implementation
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments
= note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default
= help: if the empty line is unintentional remove it
|
called `map(..).flatten()` on `Option`:
azalea/src/pathfinder/simulation.rs#L157
warning: called `map(..).flatten()` on `Option`
--> azalea/src/pathfinder/simulation.rs:157:14
|
157 | .map(|c| *c)
| ______________^
158 | | .flatten()
| |______________________^ help: try replacing `map` with `and_then` and remove the `.flatten()`: `and_then(|c| *c)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten
= note: `#[warn(clippy::map_flatten)]` on by default
|
the following explicit lifetimes could be elided: 'w, 's:
azalea/src/nearest_entity.rs#L60
warning: the following explicit lifetimes could be elided: 'w, 's
--> azalea/src/nearest_entity.rs:60:6
|
60 | impl<'w, 's, 'a, F> EntityFinder<'w, 's, F>
| ^^ ^^ ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
= note: `#[warn(clippy::needless_lifetimes)]` on by default
help: elide the lifetimes
|
60 - impl<'w, 's, 'a, F> EntityFinder<'w, 's, F>
60 + impl<'a, F> EntityFinder<'_, '_, F>
|
|
empty line after doc comment:
azalea-client/src/raw_connection.rs#L24
warning: empty line after doc comment
--> azalea-client/src/raw_connection.rs:24:5
|
24 | / /// Packets sent to this will be sent to the server.
25 | |
| |_
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments
= note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default
= help: if the empty line is unintentional remove it
help: if the documentation should include the empty line include it in the comment
|
25 | ///
|
|
large size difference between variants:
azalea-client/src/local_player.rs#L141
warning: large size difference between variants
--> azalea-client/src/local_player.rs:141:1
|
141 | / pub enum HandlePacketError {
142 | | #[error("{0}")]
143 | | Poison(String),
| | -------------- the second-largest variant contains at least 24 bytes
144 | | #[error(transparent)]
... |
149 | | Send(#[from] mpsc::error::SendError<AzaleaEvent>),
| | ------------------------------------------------- the largest variant contains at least 232 bytes
150 | | }
| |_^ the entire enum is at least 0 bytes
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant
= note: `#[warn(clippy::large_enum_variant)]` on by default
help: consider boxing the large fields to reduce the total size of the enum
|
149 | Send(#[from] Box<mpsc::error::SendError<AzaleaEvent>>),
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
the following explicit lifetimes could be elided: 'a:
azalea-protocol/src/lib.rs#L43
warning: the following explicit lifetimes could be elided: 'a
--> azalea-protocol/src/lib.rs:43:6
|
43 | impl<'a> TryFrom<&'a str> for ServerAddress {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
= note: `#[warn(clippy::needless_lifetimes)]` on by default
help: elide the lifetimes
|
43 - impl<'a> TryFrom<&'a str> for ServerAddress {
43 + impl TryFrom<&str> for ServerAddress {
|
|
the following explicit lifetimes could be elided: 'a:
azalea-world/src/find_blocks.rs#L158
warning: the following explicit lifetimes could be elided: 'a
--> azalea-world/src/find_blocks.rs:158:6
|
158 | impl<'a> Iterator for FindBlocks<'a> {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
158 - impl<'a> Iterator for FindBlocks<'a> {
158 + impl Iterator for FindBlocks<'_> {
|
|
the following explicit lifetimes could be elided: 'a:
azalea-world/src/bit_storage.rs#L231
warning: the following explicit lifetimes could be elided: 'a
--> azalea-world/src/bit_storage.rs:231:6
|
231 | impl<'a> Iterator for BitStorageIter<'a> {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
= note: `#[warn(clippy::needless_lifetimes)]` on by default
help: elide the lifetimes
|
231 - impl<'a> Iterator for BitStorageIter<'a> {
231 + impl Iterator for BitStorageIter<'_> {
|
|
manually reimplementing `div_ceil`:
azalea-world/src/bit_storage.rs#L122
warning: manually reimplementing `div_ceil`
--> azalea-world/src/bit_storage.rs:122:33
|
122 | let calculated_length = (size + values_per_long - 1) / values_per_long;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `size.div_ceil(values_per_long)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil
= note: `#[warn(clippy::manual_div_ceil)]` on by default
|
clippy_check
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
clippy_check
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/cache@v3, actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
clippy_check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
clippy_check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
clippy_check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
clippy_check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|