Skip to content

Fix debug warning (#186) #1958

Fix debug warning (#186)

Fix debug warning (#186) #1958

Triggered via push November 23, 2024 03:30
Status Failure
Total duration 2m 38s
Artifacts

check.yml

on: push
Fit to window
Zoom out
Zoom in

Annotations

1 error and 13 warnings
clippy_check
Clippy had exited with the 101 exit code
the following explicit lifetimes could be elided: 'a: azalea-protocol/src/lib.rs#L43
warning: the following explicit lifetimes could be elided: 'a --> azalea-protocol/src/lib.rs:43:6 | 43 | impl<'a> TryFrom<&'a str> for ServerAddress { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 43 - impl<'a> TryFrom<&'a str> for ServerAddress { 43 + impl TryFrom<&str> for ServerAddress { |
the following explicit lifetimes could be elided: 'a: azalea-protocol/src/read.rs#L245
warning: the following explicit lifetimes could be elided: 'a --> azalea-protocol/src/read.rs:245:30 | 245 | pub async fn read_raw_packet<'a, R>( | ^^ 246 | stream: &'a mut R, | ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
the following explicit lifetimes could be elided: 'a: azalea-protocol/src/read.rs#L212
warning: the following explicit lifetimes could be elided: 'a --> azalea-protocol/src/read.rs:212:26 | 212 | pub async fn read_packet<'a, P: ProtocolPacket + Debug, R>( | ^^ 213 | stream: &'a mut R, | ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes = note: `#[warn(clippy::needless_lifetimes)]` on by default
the following explicit lifetimes could be elided: 'a: azalea-world/src/find_blocks.rs#L158
warning: the following explicit lifetimes could be elided: 'a --> azalea-world/src/find_blocks.rs:158:6 | 158 | impl<'a> Iterator for FindBlocks<'a> { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 158 - impl<'a> Iterator for FindBlocks<'a> { 158 + impl Iterator for FindBlocks<'_> { |
the following explicit lifetimes could be elided: 'a: azalea-world/src/bit_storage.rs#L231
warning: the following explicit lifetimes could be elided: 'a --> azalea-world/src/bit_storage.rs:231:6 | 231 | impl<'a> Iterator for BitStorageIter<'a> { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes = note: `#[warn(clippy::needless_lifetimes)]` on by default help: elide the lifetimes | 231 - impl<'a> Iterator for BitStorageIter<'a> { 231 + impl Iterator for BitStorageIter<'_> { |
manually reimplementing `div_ceil`: azalea-world/src/bit_storage.rs#L122
warning: manually reimplementing `div_ceil` --> azalea-world/src/bit_storage.rs:122:33 | 122 | let calculated_length = (size + values_per_long - 1) / values_per_long; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `size.div_ceil(values_per_long)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil = note: `#[warn(clippy::manual_div_ceil)]` on by default
the following explicit lifetimes could be elided: 'a: azalea-auth/src/auth.rs#L71
warning: the following explicit lifetimes could be elided: 'a --> azalea-auth/src/auth.rs:71:19 | 71 | pub async fn auth<'a>(email: &str, opts: AuthOpts<'a>) -> Result<AuthResult, AuthError> { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes = note: `#[warn(clippy::needless_lifetimes)]` on by default
clippy_check
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
clippy_check
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/cache@v3, actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
clippy_check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
clippy_check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
clippy_check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
clippy_check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/