cache mining costs of block positions #1654
mat-1Annotations
9 warnings
|
this `else { if .. }` block can be collapsed:
azalea/src/pathfinder/moves/basic.rs#L411
warning: this `else { if .. }` block can be collapsed
--> azalea/src/pathfinder/moves/basic.rs:411:12
|
411 | } else {
| ____________^
412 | | if ctx.mine_while_at_start(target) {
413 | | ctx.walk(WalkDirection::None);
414 | | } else if BlockPos::from(position) != target {
... |
419 | | }
420 | | }
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_else_if
= note: `#[warn(clippy::collapsible_else_if)]` on by default
help: collapse nested if block
|
411 ~ } else if ctx.mine_while_at_start(target) {
412 + ctx.walk(WalkDirection::None);
413 + } else if BlockPos::from(position) != target {
414 + ctx.look_at(target_center);
415 + ctx.walk(WalkDirection::Forward);
416 + } else {
417 + ctx.walk(WalkDirection::None);
418 + }
|
|
|
lint `clippy::vtable_address_comparisons` has been renamed to `ambiguous_wide_pointer_comparisons`:
azalea-brigadier/src/tree/mod.rs#L297
warning: lint `clippy::vtable_address_comparisons` has been renamed to `ambiguous_wide_pointer_comparisons`
--> azalea-brigadier/src/tree/mod.rs:297:25
|
297 | #[allow(clippy::vtable_address_comparisons)]
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use the new name: `ambiguous_wide_pointer_comparisons`
|
= note: `#[warn(renamed_and_removed_lints)]` on by default
|
|
this `else { if .. }` block can be collapsed:
azalea/src/pathfinder/moves/basic.rs#L411
warning: this `else { if .. }` block can be collapsed
--> azalea/src/pathfinder/moves/basic.rs:411:12
|
411 | } else {
| ____________^
412 | | if ctx.mine_while_at_start(target) {
413 | | ctx.walk(WalkDirection::None);
414 | | } else if BlockPos::from(position) != target {
... |
419 | | }
420 | | }
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_else_if
= note: `#[warn(clippy::collapsible_else_if)]` on by default
help: collapse nested if block
|
411 ~ } else if ctx.mine_while_at_start(target) {
412 + ctx.walk(WalkDirection::None);
413 + } else if BlockPos::from(position) != target {
414 + ctx.look_at(target_center);
415 + ctx.walk(WalkDirection::Forward);
416 + } else {
417 + ctx.walk(WalkDirection::None);
418 + }
|
|
|
lint `clippy::vtable_address_comparisons` has been renamed to `ambiguous_wide_pointer_comparisons`:
azalea-brigadier/src/tree/mod.rs#L297
warning: lint `clippy::vtable_address_comparisons` has been renamed to `ambiguous_wide_pointer_comparisons`
--> azalea-brigadier/src/tree/mod.rs:297:25
|
297 | #[allow(clippy::vtable_address_comparisons)]
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use the new name: `ambiguous_wide_pointer_comparisons`
|
= note: `#[warn(renamed_and_removed_lints)]` on by default
|
|
clippy_check
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
clippy_check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
clippy_check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
clippy_check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
clippy_check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|