warning: usage of a legacy numeric constant --> azalea-client/src/task_pool.rs:80:30 | 80 | max_threads: std::usize::MAX, | ^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants help: use the associated constant instead | 80 | max_threads: usize::MAX, | ~~~~~~~~~~

warning: usage of a legacy numeric constant --> azalea-client/src/task_pool.rs:61:32 | 61 | max_total_threads: std::usize::MAX, | ^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants = note: `#[warn(clippy::legacy_numeric_constants)]` on by default help: use the associated constant instead | 61 | max_total_threads: usize::MAX, | ~~~~~~~~~~

warning: assigning the result of `Clone::clone()` may be inefficient --> azalea-client/src/packet_handling/game.rs:560:29 | 560 | ... info.display_name = updated_info.display_name.clone(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_from()`: `info.display_name.clone_from(&updated_info.display_name)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones = note: `#[warn(clippy::assigning_clones)]` on by default

warning: casting to the same type is unnecessary (`i32` -> `i32`) --> azalea-client/src/inventory.rs:255:44 | 255 | ... || item_stack.count() as i32 >= self.quick_craft_slots.len() as i32 | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `item_stack.count()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast = note: `#[warn(clippy::unnecessary_cast)]` on by default

warning: this expression creates a reference which is immediately dereferenced by the compiler --> azalea-physics/src/collision/shape.rs:326:49 | 326 | IndexMerger::new_indirect(&coords1, &coords2, var3, var4) | ^^^^^^^^ help: change this to: `coords2` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression creates a reference which is immediately dereferenced by the compiler --> azalea-physics/src/collision/shape.rs:326:39 | 326 | IndexMerger::new_indirect(&coords1, &coords2, var3, var4) | ^^^^^^^^ help: change this to: `coords1` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `#[warn(clippy::needless_borrow)]` on by default

warning: assigning the result of `Clone::clone()` may be inefficient --> azalea-brigadier/src/context/command_context_builder.rs:83:9 | 83 | self.modifier = node.read().modifier.clone(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_from()`: `self.modifier.clone_from(&node.read().modifier)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones

warning: assigning the result of `Clone::clone()` may be inefficient --> azalea-brigadier/src/context/command_context_builder.rs:66:9 | 66 | self.command = command.clone(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_from()`: `self.command.clone_from(command)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones = note: `#[warn(clippy::assigning_clones)]` on by default

warning: using `clone` on type `DataComponentKind` which implements the `Copy` trait --> azalea-inventory/src/slot.rs:250:31 | 250 | components.insert(kind.clone(), component.as_ref().map(|c| (*c).clone())); | ^^^^^^^^^^^^ help: try dereferencing it: `*kind` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy = note: `#[warn(clippy::clone_on_copy)]` on by default

warning: you seem to want to iterate on a map's values --> azalea-inventory/src/slot.rs:216:31 | 216 | for (_, component) in &self.components { | ^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map = note: `#[warn(clippy::for_kv_map)]` on by default help: use the corresponding method | 216 | for component in self.components.values() { | ~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~

warning: you seem to be trying to use `&Box<T>`. Consider using just `&T` --> azalea-inventory/src/slot.rs:182:17 | 182 | ) -> Option<&Box<dyn components::EncodableDataComponent>> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&dyn components::EncodableDataComponent` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box = note: `#[warn(clippy::borrowed_box)]` on by default

warning: casting to the same type is unnecessary (`i32` -> `i32`) --> azalea-inventory/src/slot.rs:151:24 | 151 | count: count as i32, | ^^^^^^^^^^^^ help: try: `count` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast = note: `#[warn(clippy::unnecessary_cast)]` on by default

warning: use of `or_insert_with` to construct default value --> azalea-core/src/registry_holder.rs:31:38 | 31 | let map = self.map.entry(id).or_insert_with(HashMap::new); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default = note: `#[warn(clippy::unwrap_or_default)]` on by default

warning: this `impl` can be derived --> azalea-registry/src/extra.rs:22:1 | 22 | / impl Default for WolfVariant { 23 | | fn default() -> Self { 24 | | WolfVariant::Pale 25 | | } 26 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls = note: `#[warn(clippy::derivable_impls)]` on by default = help: remove the manual implementation... help: ...and instead derive it... | 8 + #[derive(Default)] 9 | registry! { | help: ...and mark the default variant | 8 + #[default] 9 | registry! { |

warning: usage of a legacy numeric method --> azalea-buf/src/write.rs:140:42 | 140 | value = (value >> 7) & (i64::max_value() >> 6); | ^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants help: use the associated constant instead | 140 | value = (value >> 7) & (i64::MAX >> 6); | ~~~

warning: usage of a legacy numeric method --> azalea-buf/src/write.rs:44:42 | 44 | value = (value >> 7) & (i32::max_value() >> 6); | ^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants = note: `#[warn(clippy::legacy_numeric_constants)]` on by default help: use the associated constant instead | 44 | value = (value >> 7) & (i32::MAX >> 6); | ~~~

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v3, actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

warning: usage of a legacy numeric constant --> azalea-client/src/task_pool.rs:80:30 | 80 | max_threads: std::usize::MAX, | ^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants help: use the associated constant instead | 80 | max_threads: usize::MAX, | ~~~~~~~~~~

warning: usage of a legacy numeric constant --> azalea-client/src/task_pool.rs:61:32 | 61 | max_total_threads: std::usize::MAX, | ^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants = note: `#[warn(clippy::legacy_numeric_constants)]` on by default help: use the associated constant instead | 61 | max_total_threads: usize::MAX, | ~~~~~~~~~~

warning: assigning the result of `Clone::clone()` may be inefficient --> azalea-client/src/packet_handling/game.rs:560:29 | 560 | ... info.display_name = updated_info.display_name.clone(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_from()`: `info.display_name.clone_from(&updated_info.display_name)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones = note: `#[warn(clippy::assigning_clones)]` on by default

warning: casting to the same type is unnecessary (`i32` -> `i32`) --> azalea-client/src/inventory.rs:255:44 | 255 | ... || item_stack.count() as i32 >= self.quick_craft_slots.len() as i32 | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `item_stack.count()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast = note: `#[warn(clippy::unnecessary_cast)]` on by default

warning: this expression creates a reference which is immediately dereferenced by the compiler --> azalea-physics/src/collision/shape.rs:326:49 | 326 | IndexMerger::new_indirect(&coords1, &coords2, var3, var4) | ^^^^^^^^ help: change this to: `coords2` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression creates a reference which is immediately dereferenced by the compiler --> azalea-physics/src/collision/shape.rs:326:39 | 326 | IndexMerger::new_indirect(&coords1, &coords2, var3, var4) | ^^^^^^^^ help: change this to: `coords1` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `#[warn(clippy::needless_borrow)]` on by default

warning: assigning the result of `Clone::clone()` may be inefficient --> azalea-brigadier/src/context/command_context_builder.rs:83:9 | 83 | self.modifier = node.read().modifier.clone(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_from()`: `self.modifier.clone_from(&node.read().modifier)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones

warning: assigning the result of `Clone::clone()` may be inefficient --> azalea-brigadier/src/context/command_context_builder.rs:66:9 | 66 | self.command = command.clone(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_from()`: `self.command.clone_from(command)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones = note: `#[warn(clippy::assigning_clones)]` on by default

warning: using `clone` on type `DataComponentKind` which implements the `Copy` trait --> azalea-inventory/src/slot.rs:250:31 | 250 | components.insert(kind.clone(), component.as_ref().map(|c| (*c).clone())); | ^^^^^^^^^^^^ help: try dereferencing it: `*kind` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy = note: `#[warn(clippy::clone_on_copy)]` on by default

warning: you seem to want to iterate on a map's values --> azalea-inventory/src/slot.rs:216:31 | 216 | for (_, component) in &self.components { | ^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map = note: `#[warn(clippy::for_kv_map)]` on by default help: use the corresponding method | 216 | for component in self.components.values() { | ~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~

warning: you seem to be trying to use `&Box<T>`. Consider using just `&T` --> azalea-inventory/src/slot.rs:182:17 | 182 | ) -> Option<&Box<dyn components::EncodableDataComponent>> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&dyn components::EncodableDataComponent` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box = note: `#[warn(clippy::borrowed_box)]` on by default

warning: casting to the same type is unnecessary (`i32` -> `i32`) --> azalea-inventory/src/slot.rs:151:24 | 151 | count: count as i32, | ^^^^^^^^^^^^ help: try: `count` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast = note: `#[warn(clippy::unnecessary_cast)]` on by default

warning: use of `or_insert_with` to construct default value --> azalea-core/src/registry_holder.rs:31:38 | 31 | let map = self.map.entry(id).or_insert_with(HashMap::new); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default = note: `#[warn(clippy::unwrap_or_default)]` on by default

warning: this `impl` can be derived --> azalea-registry/src/extra.rs:22:1 | 22 | / impl Default for WolfVariant { 23 | | fn default() -> Self { 24 | | WolfVariant::Pale 25 | | } 26 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls = note: `#[warn(clippy::derivable_impls)]` on by default = help: remove the manual implementation... help: ...and instead derive it... | 8 + #[derive(Default)] 9 | registry! { | help: ...and mark the default variant | 8 + #[default] 9 | registry! { |

warning: usage of a legacy numeric method --> azalea-buf/src/write.rs:140:42 | 140 | value = (value >> 7) & (i64::max_value() >> 6); | ^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants help: use the associated constant instead | 140 | value = (value >> 7) & (i64::MAX >> 6); | ~~~