BLAZINGLY FAST 🚀🚀🚀 pathfinding

azalea-core/src/position.rs

@@ -261,6 +261,7 @@ impl ChunkSectionPos {
 }
 /// The coordinates of a block inside a chunk.
 #[derive(Clone, Copy, Debug, Default, PartialEq, Eq)]
+#[repr(align(8))]
 pub struct ChunkBlockPos {
     pub x: u8,
     pub y: i32,
@@ -273,9 +274,33 @@ impl ChunkBlockPos {
     }
 }
 
+impl Hash for ChunkBlockPos {
+    // optimized hash that only calls hash once
+    #[inline]
+    fn hash<H: std::hash::Hasher>(&self, state: &mut H) {
+        u64::from(*self).hash(state);
+    }
+}
+impl From<ChunkBlockPos> for u64 {
+    #[inline]
+    fn from(pos: ChunkBlockPos) -> Self {
+        // convert to u64
+        let mut val: u64 = 0;
+        // first 32 bits are y
+        val |= pos.y as u64;
+        // next 8 bits are z
+        val |= (pos.z as u64) << 32;
+        // last 8 bits are x
+        val |= (pos.x as u64) << 40;
+        val
+    }
+}
+impl nohash_hasher::IsEnabled for ChunkBlockPos {}
+
 /// The coordinates of a block inside a chunk section. Each coordinate must be
 /// in the range [0, 15].
 #[derive(Clone, Copy, Debug, Default, PartialEq, Eq)]
+#[repr(align(4))]
 pub struct ChunkSectionBlockPos {
     pub x: u8,
     pub y: u8,
@@ -294,6 +319,28 @@ impl Add<ChunkSectionBlockPos> for ChunkSectionPos {
         )
     }
 }
+impl Hash for ChunkSectionBlockPos {
+    // optimized hash that only calls hash once
+    #[inline]
+    fn hash<H: std::hash::Hasher>(&self, state: &mut H) {
+        u16::from(*self).hash(state);
+    }
+}
+
+impl From<ChunkSectionBlockPos> for u16 {
+    #[inline]
+    fn from(pos: ChunkSectionBlockPos) -> Self {
+        let mut val: u16 = 0;
+        // first 4 bits are z
+        val |= pos.z as u16;
+        // next 4 bits are y
+        val |= (pos.y as u16) << 4;
+        // last 4 bits are x
+        val |= (pos.x as u16) << 8;
+        val
+    }
+}
+impl nohash_hasher::IsEnabled for ChunkSectionBlockPos {}
 
 /// A block pos with an attached world
 #[derive(Debug, Clone)]
@@ -312,22 +359,33 @@ impl From<&BlockPos> for ChunkPos {
         }
     }
 }
+impl From<BlockPos> for ChunkPos {
+    #[inline]
+    fn from(pos: BlockPos) -> Self {
+        ChunkPos {
+            x: pos.x.div_floor(16),
+            z: pos.z.div_floor(16),
+        }
+    }
+}
 
 impl From<BlockPos> for ChunkSectionPos {
+    #[inline]
     fn from(pos: BlockPos) -> Self {
         ChunkSectionPos {
-            x: pos.x.div_floor(16),
-            y: pos.y.div_floor(16),
-            z: pos.z.div_floor(16),
+            x: pos.x >> 4,
+            y: pos.y >> 4,
+            z: pos.z >> 4,
         }
     }
 }
 impl From<&BlockPos> for ChunkSectionPos {
+    #[inline]
     fn from(pos: &BlockPos) -> Self {
         ChunkSectionPos {
-            x: pos.x.div_floor(16),
-            y: pos.y.div_floor(16),
-            z: pos.z.div_floor(16),
+            x: pos.x >> 4,
+            y: pos.y >> 4,
+            z: pos.z >> 4,
         }
     }
 }
@@ -348,17 +406,28 @@ impl From<&BlockPos> for ChunkBlockPos {
         }
     }
 }
-
-impl From<&BlockPos> for ChunkSectionBlockPos {
-    fn from(pos: &BlockPos) -> Self {
-        ChunkSectionBlockPos {
+impl From<BlockPos> for ChunkBlockPos {
+    #[inline]
+    fn from(pos: BlockPos) -> Self {
+        ChunkBlockPos {
             x: pos.x.rem_euclid(16) as u8,
-            y: pos.y.rem_euclid(16) as u8,
+            y: pos.y,
             z: pos.z.rem_euclid(16) as u8,
         }
     }
 }
 
+impl From<BlockPos> for ChunkSectionBlockPos {
+    #[inline]
+    fn from(pos: BlockPos) -> Self {
+        ChunkSectionBlockPos {
+            x: pos.x as u8 & 0xF,
+            y: pos.y as u8 & 0xF,
+            z: pos.z as u8 & 0xF,
+        }
+    }
+}
+
 impl From<&ChunkBlockPos> for ChunkSectionBlockPos {
     #[inline]
     fn from(pos: &ChunkBlockPos) -> Self {
@@ -529,7 +598,7 @@ mod tests {
     fn test_into_chunk_section_block_pos() {
         let block_pos = BlockPos::new(0, -60, 0);
         assert_eq!(
-            ChunkSectionBlockPos::from(&block_pos),
+            ChunkSectionBlockPos::from(block_pos),
             ChunkSectionBlockPos::new(0, 4, 0)
         );
     }

azalea/src/pathfinder/moves/basic.rs

@@ -14,7 +14,7 @@ use crate::{
 use super::{default_is_reached, Edge, ExecuteCtx, IsReachedCtx, MoveData, PathfinderCtx};
 
 pub fn basic_move(ctx: &PathfinderCtx, node: BlockPos) -> Vec<Edge> {
-    let mut edges = Vec::new();
+    let mut edges = Vec::with_capacity(8);
     edges.extend(forward_move(ctx, node));
     edges.extend(ascend_move(ctx, node));
     edges.extend(descend_move(ctx, node));
@@ -27,7 +27,7 @@ fn forward_move(ctx: &PathfinderCtx, pos: BlockPos) -> Vec<Edge> {
     for dir in CardinalDirection::iter() {
         let offset = BlockPos::new(dir.x(), 0, dir.z());
 
-        if !ctx.is_standable(&(pos + offset)) {
+        if !ctx.is_standable(pos + offset) {
             continue;
         }
 
@@ -73,10 +73,10 @@ fn ascend_move(ctx: &PathfinderCtx, pos: BlockPos) -> Vec<Edge> {
     for dir in CardinalDirection::iter() {
         let offset = BlockPos::new(dir.x(), 1, dir.z());
 
-        if !ctx.is_block_passable(&pos.up(2)) {
+        if !ctx.is_block_passable(pos.up(2)) {
             continue;
         }
-        if !ctx.is_standable(&(pos + offset)) {
+        if !ctx.is_standable(pos + offset) {
             continue;
         }
 
@@ -157,18 +157,18 @@ fn descend_move(ctx: &PathfinderCtx, pos: BlockPos) -> Vec<Edge> {
     for dir in CardinalDirection::iter() {
         let dir_delta = BlockPos::new(dir.x(), 0, dir.z());
         let new_horizontal_position = pos + dir_delta;
-        let fall_distance = ctx.fall_distance(&new_horizontal_position);
+        let fall_distance = ctx.fall_distance(new_horizontal_position);
         if fall_distance == 0 || fall_distance > 3 {
             continue;
         }
         let new_position = new_horizontal_position.down(fall_distance as i32);
 
         // check whether 3 blocks vertically forward are passable
-        if !ctx.is_passable(&new_horizontal_position) {
+        if !ctx.is_passable(new_horizontal_position) {
             continue;
         }
         // check whether we can stand on the target position
-        if !ctx.is_standable(&new_position) {
+        if !ctx.is_standable(new_position) {
             continue;
         }
 
@@ -266,16 +266,16 @@ fn diagonal_move(ctx: &PathfinderCtx, pos: BlockPos) -> Vec<Edge> {
         let right = dir.right();
         let offset = BlockPos::new(dir.x() + right.x(), 0, dir.z() + right.z());
 
-        if !ctx.is_passable(&BlockPos::new(pos.x + dir.x(), pos.y, pos.z + dir.z()))
-            && !ctx.is_passable(&BlockPos::new(
+        if !ctx.is_passable(BlockPos::new(pos.x + dir.x(), pos.y, pos.z + dir.z()))
+            && !ctx.is_passable(BlockPos::new(
                 pos.x + dir.right().x(),
                 pos.y,
                 pos.z + dir.right().z(),
             ))
         {
             continue;
         }
-        if !ctx.is_standable(&(pos + offset)) {
+        if !ctx.is_standable(pos + offset) {
             continue;
         }
         // +0.001 so it doesn't unnecessarily go diagonal sometimes