Enchantments #286
Open
Enchantments #286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
I think I'm gonna wait until 1.21.11 is released before merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hehe
53 files changed, 2334 insertions(+), 835 deletions(-)jumpscare :3This PR refactors registries so
RegistryHolderno longer represents all registries internally as NBT (partially based on past conversations I had with @urisinger), it implements definitions for most parts of the enchantment registry, and it adds support for attribute-based enchantments (i.e. efficiency).Note that some of the definitions are written in ugly ways due to current limitations with simdnbt, hopefully that can be improved soon.