partially implement 24w35a #1899
clippy
11 warnings
Details
Results
Message level | Amount |
---|---|
Internal compiler error | 0 |
Error | 0 |
Warning | 11 |
Note | 0 |
Help | 0 |
Versions
- rustc 1.83.0-nightly (fa724e5d8 2024-09-27)
- cargo 1.83.0-nightly (eaee77dc1 2024-09-19)
- clippy 0.1.83 (fa724e5 2024-09-27)
Annotations
Check warning on line 551 in azalea/src/swarm/mod.rs
github-actions / clippy
empty line after doc comment
warning: empty line after doc comment
--> azalea/src/swarm/mod.rs:550:1
|
550 | / /// }
551 | |
| |_
552 | impl Swarm {
| ---------- the comment documents this implementation
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments
= note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default
= help: if the empty line is unintentional remove it
Check warning on line 160 in azalea/src/pathfinder/simulation.rs
github-actions / clippy
called `map(..).flatten()` on `Option`
warning: called `map(..).flatten()` on `Option`
--> azalea/src/pathfinder/simulation.rs:159:14
|
159 | .map(|c| *c)
| ______________^
160 | | .flatten()
| |______________________^ help: try replacing `map` with `and_then` and remove the `.flatten()`: `and_then(|c| *c)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten
= note: `#[warn(clippy::map_flatten)]` on by default
Check warning on line 11 in azalea/src/pathfinder/debug.rs
github-actions / clippy
first doc comment paragraph is too long
warning: first doc comment paragraph is too long
--> azalea/src/pathfinder/debug.rs:7:1
|
7 | / /// A component that makes bots run /particle commands while pathfinding to show
8 | | /// where they're going. This requires the bots to have server operator
9 | | /// permissions, and it'll make them spam *a lot* of commands.
10 | | ///
11 | | /// ```
| |_
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_long_first_doc_paragraph
= note: `#[warn(clippy::too_long_first_doc_paragraph)]` on by default
Check warning on line 25 in azalea-client/src/raw_connection.rs
github-actions / clippy
empty line after doc comment
warning: empty line after doc comment
--> azalea-client/src/raw_connection.rs:24:5
|
24 | / /// Packets sent to this will be sent to the server.
25 | |
| |_
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments
= note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default
= help: if the empty line is unintentional remove it
help: if the documentation should include the empty line include it in the comment
|
25 | ///
|
Check warning on line 18 in azalea-client/src/raw_connection.rs
github-actions / clippy
first doc comment paragraph is too long
warning: first doc comment paragraph is too long
--> azalea-client/src/raw_connection.rs:16:1
|
16 | / /// A component for clients that can read and write packets to the server. This
17 | | /// works with raw bytes, so you'll have to serialize/deserialize packets
18 | | /// yourself. It will do the compression and encryption for you though.
| |_
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_long_first_doc_paragraph
Check warning on line 21 in azalea-client/src/packet_handling/login.rs
github-actions / clippy
first doc comment paragraph is too long
warning: first doc comment paragraph is too long
--> azalea-client/src/packet_handling/login.rs:18:1
|
18 | / /// An event that's sent when we receive a login packet from the server. Note
19 | | /// that if you want to handle this in a system, you must add
20 | | /// `.before(azalea::packet_handling::login::process_packet_events)` to it
21 | | /// because that system clears the events.
| |_
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_long_first_doc_paragraph
Check warning on line 483 in azalea-client/src/movement.rs
github-actions / clippy
first doc comment paragraph is too long
warning: first doc comment paragraph is too long
--> azalea-client/src/movement.rs:480:1
|
480 | / /// An event sent by the server that sets or adds to our velocity. Usually
481 | | /// `KnockbackKind::Set` is used for normal knockback and `KnockbackKind::Add`
482 | | /// is used for explosions, but some servers (notably Hypixel) use explosions
483 | | /// for knockback.
| |_
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_long_first_doc_paragraph
= note: `#[warn(clippy::too_long_first_doc_paragraph)]` on by default
Check warning on line 150 in azalea-client/src/local_player.rs
github-actions / clippy
large size difference between variants
warning: large size difference between variants
--> azalea-client/src/local_player.rs:141:1
|
141 | / pub enum HandlePacketError {
142 | | #[error("{0}")]
143 | | Poison(String),
| | -------------- the second-largest variant contains at least 24 bytes
144 | | #[error(transparent)]
... |
149 | | Send(#[from] mpsc::error::SendError<AzaleaEvent>),
| | ------------------------------------------------- the largest variant contains at least 232 bytes
150 | | }
| |_^ the entire enum is at least 0 bytes
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant
= note: `#[warn(clippy::large_enum_variant)]` on by default
help: consider boxing the large fields to reduce the total size of the enum
|
149 | Send(#[from] Box<mpsc::error::SendError<AzaleaEvent>>),
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Check warning on line 47 in azalea-world/src/chunk_storage.rs
github-actions / clippy
first doc comment paragraph is too long
warning: first doc comment paragraph is too long
--> azalea-world/src/chunk_storage.rs:44:1
|
44 | / /// A single chunk in a world (16*?*16 blocks). This only contains the blocks
45 | | /// and biomes. You can derive the height of the chunk from the number of
46 | | /// sections, but you need a [`ChunkStorage`] to get the minimum Y
47 | | /// coordinate.
| |_
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_long_first_doc_paragraph
= note: `#[warn(clippy::too_long_first_doc_paragraph)]` on by default
Check warning on line 122 in azalea-world/src/bit_storage.rs
github-actions / clippy
manually reimplementing `div_ceil`
warning: manually reimplementing `div_ceil`
--> azalea-world/src/bit_storage.rs:122:33
|
122 | let calculated_length = (size + values_per_long - 1) / values_per_long;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `size.div_ceil(values_per_long)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil
= note: `#[warn(clippy::manual_div_ceil)]` on by default
Check warning on line 128 in azalea-auth/src/sessionserver.rs
github-actions / clippy
first doc comment paragraph is too long
warning: first doc comment paragraph is too long
--> azalea-auth/src/sessionserver.rs:125:1
|
125 | / /// Ask Mojang's servers if the player joining is authenticated.
126 | | /// Included in the reply is the player's skin and cape.
127 | | /// The IP field is optional and equivalent to enabling
128 | | /// 'prevent-proxy-connections' in server.properties
| |_
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_long_first_doc_paragraph
= note: `#[warn(clippy::too_long_first_doc_paragraph)]` on by default
help: add an empty line
|
125 ~ /// Ask Mojang's servers if the player joining is authenticated.
126 + ///
|