Skip to content

Improvements and changes #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
vlad-roid wants to merge 53 commits into
base: master
Choose a base branch
from
Open

Improvements and changes #6

vlad-roid wants to merge 53 commits into from

Conversation

@vlad-roid
Copy link

@vlad-roid vlad-roid commented Oct 9, 2019 •
edited
Loading

Differences in this branch from original repository

  • Added a "no color" option (transparent color value)
  • Original bitmap generation was prone to crashes, which are instead caught in this fork's source code
  • Original HuePicker, OpacityPicker and SatValPicker have memory leaks, which are fixed in this fork's code
  • For the above changes, HuePicker provides the method setBitmapGenerationFailedListener which listens for bitmap generation failure; ColorPickerDialog uses this listener to automatically reattempt reloading the bitmap every second while the dialog is still showing
  • Migrated from legacy support library to AndroidX AppCompat v1.1.0, leaving inflation of the correct Button classes to the implementations of this library

Other internal changes:

  • Library updates: Gradle wrapper 3.3 -> 5.4.1; Gradle build tools 2.2.0 -> 3.5.1; Maven gradle plugin 1.5 -> 2.0; Compile/Target Android SDK level 25 -> 29; Min Android SDK level 11 -> 14; Android build tools 23.0.3 -> 29.0.2
  • Switched from deprecated compile to api in build.gradle
  • Fixed spelling mistake "dialog_edit_color_root.xml"
  • Removed application declaration from manifest to prevent transitive changes
  • Added missing items to .gitignore
  • Standard Android Studio source code formatting
  • Minor refactoring inside onInterceptTouchEvent of ScrollViews
  • Removed redundant minSizePx variable from HuePicker and OpacityPicker

alexandre-g and others added 30 commits March 15, 2017 13:45
@alexandre-g
Preparing for jitpack
1a6c311
@alexandre-g
Adding 'no color' button
5387bfe
@alexandre-g
No-color button fix and layout tweaks
497d0ae
@vlad-roid
Merge branch 'master' of https://github.com/AzeeSoft/AndroidPhotoshop…
7307c2a 
…ColorPicker
@vlad-roid
Fixed crashes in BitmapsGenerator
c340794
@vlad-roid
Fixed Context memory leaks in all picker classes
2f2515f
@vlad-roid
Code formatting and refactoring
3cfdeb8
@vlad-roid
Gradle wrapper 3.3 -> 5.4.1; Gradle build tools 2.2.0 -> 3.5.0; Maven…
52f466d 
… gradle plugin 1.5 -> 2.0; Compile/Target Android SDK level 25 -> 29; Min Android SDK level 11 -> 14; Android build tools 23.0.3 -> 29.0.2
@vlad-roid
Migrated from legacy support library to AndroidX; Fixed "dialod"
c1fbee8
@vlad-roid
Removed application declaration from manifest to prevent transitive c…
f5bcfab 
…hanges
@vlad-roid
Updated .gitignore
9050055
@vlad-roid
Library version 1.1.2 -> 1.2.0
88261ad
@vlad-roid
Update README.md
85536bc
@vlad-roid
Update README.md
b728deb
@vlad-roid
No color option tweaks
4be7d9c
@vlad-roid
renamed dialog_root -> dialog_color_picker_root as a precaution so us…
2eb3225 
…ers of the library don't accidentally overwrite the layout
@vlad-roid
Gradle build tools 3.5.0 -> 3.5.1
a67842c
@vlad-roid
Revert commit "Preparing for jitpack" and set version to 1.1.0
e18828b
@vlad-roid
Added showing "no color" option via style/theme
f953e05
@vlad-roid
Reverted readme changes for pull request
cfb3748
@vlad-roid
Update README.md
24bda9c
@vlad-roid
Merge remote-tracking branch 'origin/master' into improvements
18b2a7b
@vlad-roid
Fixed Android 4.0 incompatibility (introduced in this fork)
e0fccb2
@vlad-roid
Renamed onBitmapGenerationFailedListener -> onBitmapGenerationFailed
a8708ff
@vlad-roid
Added onBitmapGenerationFailedListener handling to ColorPickerDialog,…
5c455f6 
… auto reattempting bitmap generation every second while the dialog is still showing
@vlad-roid
Android Studio standard formatting
f4aaf0a
@vlad-roid
Removed redundant AppTheme styles
94e17f4
@vlad-roid
Merge branch 'master' into improvements
123957e 
# Conflicts:
#	README.md
@vlad-roid
Gradle build tools 3.5.1 -> 3.6.0
f71b076
@vlad-roid
Android build tools 29.0.2 -> 29.0.3
ac0936e
@vlad-roid
Renamed OrientedSeekBar orientation attr to cp_orientation to avoid c…
0d30fb7 
…onflicts with androidx.gridlayout
@vlad-roid
Gradlew wrapper 5.4.1 -> 6.2.1
d0ac5ef
@vlad-roid
Added android.useAndroidX=true
d0d3c24
@vlad-roid
Library version 1.2.0 -> 1.2.1
624bdaa
@vlad-roid
Merge branch 'master' into improvements
2e2f440 
# Conflicts:
#	build.gradle
@vlad-roid
Update README.md
e69aa8a
@vlad-roid
Update README.md
40d08fd
@vlad-roid
Library version 1.2.1 -> 1.2.2
70465d4
@vlad-roid
Merge remote-tracking branch 'origin/master'
136a682
@vlad-roid
Update README.md
02dd5c1
@vlad-roid
Gradle build tools 3.6.0 -> 3.6.1
896735a
@vlad-roid
Moved mipmap-xxxhdpi to mipmap
86c7f7b
@vlad-roid
Changed pressed state of SatValPicker to accent color
6413c45
@vlad-roid
Library version 1.2.2 -> 1.2.3
1eda188
@vlad-roid
Update README.md
fa62968
@vlad-roid
Merge remote-tracking branch 'origin/master'
bf1ca68 
# Conflicts:
#	README.md
@vlad-roid
Merge branch 'master' into improvements
8c392df 
# Conflicts:
#	README.md
#	build.gradle
@vlad-roid
Fix for commit: Renamed OrientedSeekBar orientation attr to cp_orient…
2daa493 
…ation to avoid conflicts with androidx.gridlayout
@vlad-roid
Fix for commit: Renamed OrientedSeekBar orientation attr to cp_orient…
d460045 
…ation to avoid conflicts with androidx.gridlayout
@vlad-roid
Library version 1.2.3 -> 1.2.4
998d2d7
@vlad-roid
Update README.md
bb93ae3
@vlad-roid
Merge branch 'master' into improvements
acfd8bf 
# Conflicts:
#	build.gradle
@vlad-roid
Merge branch 'master' into improvements
8a300be 
# Conflicts:
#	README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vlad-roid @alexandre-g