Allow PHP 8.4

.github/workflows/benchmarks.yml

@@ -13,7 +13,7 @@ jobs:
     strategy:
       matrix:
         php-version:
-          - "8.3"
+          - "8.4"
         operating-system:
           - "ubuntu-latest"
 

.github/workflows/code-coverage.yml

@@ -17,7 +17,7 @@ jobs:
       - name: "installing PHP"
         uses: "shivammathur/setup-php@v2"
         with:
-          php-version: "8.3"
+          php-version: "8.4"
           ini-values: memory_limit=-1
           tools: composer:v2, cs2pr
           extensions: bcmath, mbstring, intl, sodium, json

.github/workflows/coding-standards.yml

@@ -15,7 +15,7 @@ jobs:
       - name: "installing PHP"
         uses: "shivammathur/setup-php@v2"
         with:
-          php-version: "8.3"
+          php-version: "8.4"
           ini-values: memory_limit=-1
           tools: composer:v2, cs2pr
           extensions: bcmath, mbstring, intl, sodium, json

.github/workflows/documentation-check.yml

@@ -15,7 +15,7 @@ jobs:
       - name: "installing PHP"
         uses: "shivammathur/setup-php@v2"
         with:
-          php-version: "8.3"
+          php-version: "8.4"
           ini-values: memory_limit=-1
           tools: composer:v2, cs2pr
           extensions: bcmath, mbstring, intl, sodium, json

.github/workflows/mutation-tests.yml

@@ -13,7 +13,7 @@ jobs:
     strategy:
       matrix:
         php-version:
-          - "8.3"
+          - "8.4"
         operating-system:
           - "ubuntu-latest"
 

.github/workflows/preload-check.yml

@@ -15,7 +15,7 @@ jobs:
       - name: "installing PHP"
         uses: "shivammathur/setup-php@v2"
         with:
-          php-version: "8.3"
+          php-version: "8.4"
           ini-values: memory_limit=-1
           tools: composer:v2, cs2pr
           extensions: bcmath, mbstring, intl, sodium, json

.github/workflows/unit-tests.yml

@@ -15,6 +15,7 @@ jobs:
         php-version:
           - "8.2"
           - "8.3"
+          - "8.4"
         operating-system:
           - "macos-latest"
           - "ubuntu-latest"

Makefile

@@ -2,7 +2,7 @@ help:
 	@awk 'BEGIN {FS = ":.*?## "} /^[a-zA-Z_\-\.]+:.*?## / {printf "\033[36m%-30s\033[0m %s\n", $$1, $$2}' $(MAKEFILE_LIST)
 
 install:                                                              			## install all dependencies for a development environment
-	composer install
+	COMPOSER_IGNORE_PLATFORM_REQ=php+ composer install
 
 coding-standard-fix:                                                            ## apply automated coding standard fixes
 	PHP_CS_FIXER_IGNORE_ENV=1 ./vendor/bin/php-cs-fixer fix --config=config/.php_cs.dist.php

composer.json

@@ -10,7 +10,7 @@
         }
     ],
     "require": {
-        "php": "~8.2.0 || ~8.3.0",
+        "php": "~8.2.0 || ~8.3.0 || ~8.4.0",
         "ext-bcmath": "*",
         "ext-json": "*",
         "ext-mbstring": "*",

src/Psl/DateTime/DateTime.php

@@ -172,14 +172,7 @@ public static function fromParts(Timezone $timezone, int $year, Month|int $month
             $month = $month->value;
         }
 
-        /**
-         * @var IntlCalendar $calendar
-         */
-        $calendar = IntlCalendar::createInstance(
-            Internal\to_intl_timezone($timezone),
-        );
-
-        $calendar->set($year, $month - 1, $day, $hours, $minutes, $seconds);
+        $calendar = Internal\create_intl_calendar_from_date_time($timezone, $year, $month, $day, $hours, $minutes, $seconds);
 
         if ($seconds !== $calendar->get(IntlCalendar::FIELD_SECOND)) {
             throw Exception\UnexpectedValueException::forSeconds($seconds, $calendar->get(IntlCalendar::FIELD_SECOND));

src/Psl/DateTime/Internal/create_intl_calendar_from_date_time.php

@@ -0,0 +1,44 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Psl\DateTime\Internal;
+
+use IntlCalendar;
+use Psl\DateTime\Timezone;
+
+/**
+ * @internal
+ *
+ * @psalm-mutation-free
+ *
+ * @psalm-suppress ImpureMethodCall - `IntlCalender::setDateTime()` is mutation free, as it performs a read-only operation.
+ *
+ * @infection-ignore-all
+ */
+function create_intl_calendar_from_date_time(
+    Timezone $timezone,
+    int $year,
+    int $month,
+    int $day,
+    int $hours,
+    int $minutes,
+    int $seconds
+): IntlCalendar {
+    /**
+     * @var IntlCalendar $calendar
+     */
+    $calendar = IntlCalendar::createInstance(
+        to_intl_timezone($timezone),
+    );
+
+    if (PHP_VERSION_ID >= 80300) {
+        $calendar->setDateTime($year, $month - 1, $day, $hours, $minutes, $seconds);
+    } else {
+        // @codeCoverageIgnoreStart
+        $calendar->set($year, $month - 1, $day, $hours, $minutes, $seconds);
+        // @codeCoverageIgnoreEnd
+    }
+
+    return $calendar;
+}

src/Psl/Internal/Loader.php

@@ -554,6 +554,7 @@ final class Loader
         'Psl\\DateTime\\Internal\\default_timezone' => 'Psl/DateTime/Internal/default_timezone.php',
         'Psl\\DateTime\\Internal\\system_time' => 'Psl/DateTime/Internal/system_time.php',
         'Psl\\DateTime\\Internal\\high_resolution_time' => 'Psl/DateTime/Internal/high_resolution_time.php',
+        'Psl\\DateTime\\Internal\\create_intl_calendar_from_date_time' => 'Psl/DateTime/Internal/create_intl_calendar_from_date_time.php',
         'Psl\\DateTime\\Internal\\create_intl_date_formatter' => 'Psl/DateTime/Internal/create_intl_date_formatter.php',
         'Psl\\DateTime\\Internal\\parse' => 'Psl/DateTime/Internal/parse.php',
         'Psl\\DateTime\\Internal\\format_rfc3339' => 'Psl/DateTime/Internal/format_rfc3339.php',