feat(option): add Option::zip(), Option::zipWith() and Option::unzip() methods
#434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 7321411656
💛 - Coveralls |
veewee
requested changes
Dec 12, 2023
veewee
reviewed
Dec 14, 2023
|
Sorry for having to review it so many times, I hope it's ready now! 😄 |
devnix
commented
Dec 17, 2023
veewee
reviewed
Dec 17, 2023
veewee
reviewed
Dec 17, 2023
|
This should do it, happy holidays! 😄 |
veewee
added
Priority: Medium
|
Thanks |
renovate bot
referenced
this pull request
in ben-challis/sql-migrations
Dec 29, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [azjezz/psl](https://togithub.com/azjezz/psl) | `2.8.0` -> `2.9.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>azjezz/psl (azjezz/psl)</summary> ### [`v2.9.0`](https://togithub.com/azjezz/psl/releases/tag/2.9.0): Lenalee - 2.9.0 [Compare Source](https://togithub.com/azjezz/psl/compare/2.8.0...2.9.0) #### What's Changed - Apply fixes for Psalm 5.17 by [@​veewee](https://togithub.com/veewee) in [https://github.com/azjezz/psl/pull/431](https://togithub.com/azjezz/psl/pull/431) - feat(type): add class_string types ([#​432](https://togithub.com/azjezz/psl/issues/432)) by [@​zerkms](https://togithub.com/zerkms) in [https://github.com/azjezz/psl/pull/435](https://togithub.com/azjezz/psl/pull/435) - feat(option): add `Option::zip()`, `Option::zipWith()` and `Option::unzip()` methods by [@​devnix](https://togithub.com/devnix) in [https://github.com/azjezz/psl/pull/434](https://togithub.com/azjezz/psl/pull/434) - feat(option): add `Option::proceed()` method by [@​devnix](https://togithub.com/devnix) in [https://github.com/azjezz/psl/pull/433](https://togithub.com/azjezz/psl/pull/433) - feat(option): new `Option::apply()` method by [@​devnix](https://togithub.com/devnix) in [https://github.com/azjezz/psl/pull/426](https://togithub.com/azjezz/psl/pull/426) #### New Contributors - [@​zerkms](https://togithub.com/zerkms) made their first contribution in [https://github.com/azjezz/psl/pull/435](https://togithub.com/azjezz/psl/pull/435) **Full Changelog**: azjezz/psl@2.8.0...2.9.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/ben-challis/sql-migrations). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMDMuMSIsInVwZGF0ZWRJblZlciI6IjM3LjEwMy4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typing
unzipgenerics has been a huge PITA. I've been able to make them work in Psalm, but not for PHPStan: phpstan/phpstan#10285Eager to get feedback 😄