feat: narrow ResultInterface to concrete implementation after calling isSucceeded() and isFailed()

[simPod]

No description provided.

[coveralls]

Pull Request Test Coverage Report for Build 8735731205

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 98.781%

---

Totals
Change from base Build 8728644504:	0.0%
Covered Lines:	4377
Relevant Lines:	4431

---

💛 - Coveralls

[veewee]

Thanks for the PR.
Seems like a nice addition!

[azjezz]

I think we need to revert this 😅 ResultInterface is part of the public API, and while it is quite unlikey, someone could re-implement Success/Failure, e.g MySuccess/MyFailure, in which case, MySuccess::isSucceeded would return true, but that does not mean its an instance of Success ( that is what psalm would think ).

repro:

function foo(ResultInterface $result): Success {
  if ($result->isSucceeded()) {
    return $result;
  }

  exit('no');
}

foo($mySuccessImplementation); // throws an exception

CRIES

[simPod]

Hm, that's true. 😢²

Should I send revert PR?

[veewee]

Woops, merged a bit too fast - sorry.
A revert PR is welcome. 😢 **3

[simPod]

There u go #469

[simPod]

BTW is there any chance the RFC is accepted in the future? (like it was missing something that could be fixed)