-
-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(collections): introduce Set
, SetInterface
, MutableSet
, and MutableSetInterface
#482
Conversation
@veewee i need |
c4ea842
to
03c9ed2
Compare
note: this change will be part of v3, but in v4, I plan on removing the current |
03c9ed2
to
25e734d
Compare
Pull Request Test Coverage Report for Build 9762814914Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just left a few minor comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a good place to start from.
I don't think the changes will break anything from my end, since I'm just using the provided classes instead of interfaces.
Added some comments here and there.
25e734d
to
bc566a7
Compare
Pull Request Test Coverage Report for Build 9977328873Details
💛 - Coveralls |
bc566a7
to
643d55f
Compare
… `MutableSetInterface` Signed-off-by: azjezz <azjezz@protonmail.com>
643d55f
to
ac60026
Compare
introduce the following new types:
Set
MutableSet
SetInterface
MutableSetInterface
map
andmapWithKeys
methods have been removed from collection interfaces, they are now present only inMap
,MutableMap
,MapInterface
,MutableMapInterface
,Vector
,MutableVector
,VectorInterface
,MutableVectorInterface
,Set
,MutableSet
,SetInterface
, andMutableSetInterface
. ( the reason is that both map and vector map using the signaturemap<U>(c: f(V): U) -> Self<K, U>
while sets map usingmap<U>(c: f(V): U) -> Self<U, U>
signature ).