Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(collections): add fromItems and containsKey #484

Merged
merged 8 commits into from
Sep 3, 2024

Conversation

pfmmfp
Copy link
Contributor

@pfmmfp pfmmfp commented Aug 21, 2024

  • Adding *::fromItems() to allow instantiating a collections from any iterable.
  • Adding *->containsKey() as an alias of contains

azjezz
azjezz previously requested changes Aug 21, 2024
src/Psl/Collection/MutableVector.php Show resolved Hide resolved
@pfmmfp pfmmfp requested a review from azjezz August 30, 2024 19:58
@pfmmfp pfmmfp changed the title feat(collections): add fromItems to MutableVector feat(collections): add fromItems and containsKey Aug 30, 2024
@coveralls
Copy link

coveralls commented Aug 31, 2024

Pull Request Test Coverage Report for Build 10684660677

Details

  • 16 of 16 (100.0%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 98.691%

Totals Coverage Status
Change from base Build 10684634337: 0.04%
Covered Lines: 5352
Relevant Lines: 5423

💛 - Coveralls

@pfmmfp pfmmfp requested a review from veewee September 3, 2024 12:23
veewee
veewee previously approved these changes Sep 3, 2024
@veewee veewee added this to the 3.0.0 milestone Sep 3, 2024
@veewee veewee merged commit d68cd6b into azjezz:next Sep 3, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants