Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update filepath for NonNullType #488

Merged
merged 1 commit into from
Sep 12, 2024
Merged

fix: update filepath for NonNullType #488

merged 1 commit into from
Sep 12, 2024

Conversation

phpjob
Copy link
Contributor

@phpjob phpjob commented Sep 11, 2024

As mentioned in the issue -> #487 the file has been moved to the global type directory (#478). But the filepath location was not updated, only the namespace. So now the file could not be loaded which leads into errors.

So i updated also the file location in this pr.

@veewee veewee added Priority: High After critical issues are fixed, these should be dealt with before any further issues. Status: Accepted It's clear what the subject of the issue is about, and what the resolution should be. Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. labels Sep 12, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10818982990

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 98.691%
Totals Coverage Status
Change from base Build 10684798974: 0.0%
Covered Lines: 5352
Relevant Lines: 5423
💛 - Coveralls

@veewee veewee merged commit 43eefa8 into azjezz:next Sep 12, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Priority: High After critical issues are fixed, these should be dealt with before any further issues. Status: Accepted It's clear what the subject of the issue is about, and what the resolution should be. Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@phpjob @coveralls @veewee