Skip to content

feat: introduce search_opt_k_v #490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 5, 2025
Merged

feat: introduce search_opt_k_v #490

merged 2 commits into from
Mar 5, 2025

Conversation

simPod
Copy link
Contributor

@simPod simPod commented Sep 12, 2024

Currently, there's no way to search iterable using also a key

Currently, there's no way to search iterable using also a key
@simPod simPod marked this pull request as ready for review September 12, 2024 12:22
@coveralls
Copy link

coveralls commented Sep 12, 2024

Pull Request Test Coverage Report for Build 10834142357

Details

  • 8 of 8 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 98.656%

Totals Coverage Status
Change from base Build 10824565385: 0.002%
Covered Lines: 5358
Relevant Lines: 5431

💛 - Coveralls

@azjezz
Copy link
Owner

azjezz commented Sep 12, 2024

we should follow existing naming convention ( e.g Vec\chunk / Vec\chunk_with_keys ).

I say we rename to Iter\search_with_keys_opt and also introduce Iter\search_with_keys for consistency.

Currently, there's no way to search iterable using also a key
@simPod
Copy link
Contributor Author

simPod commented Sep 12, 2024

adapted

@azjezz azjezz merged commit 5f735e9 into azjezz:next Mar 5, 2025
14 checks passed
@simPod simPod deleted the searchkv branch March 5, 2025 10:56
devnix pushed a commit to devnix/psl that referenced this pull request Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants