Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added naming convention support for search service module #269

Merged
merged 1 commit into from
Jan 16, 2024
Merged

Added naming convention support for search service module #269

merged 1 commit into from
Jan 16, 2024

Conversation

leelasatyavathip
Copy link
Contributor

Issue-id

PR Checklist

  • I have read the CONTRIBUTING.MD instructions
  • I have changed the resourceDefinition.json
  • I have generated the resource model (there's a models_generated.go file in my PR)
  • I have updated the README.md#resource-status
  • I have checked to ensure there aren't other open Pull Requests for the same update/change?

Description

Added support to Azure Search service naming convention

Does this introduce a breaking change

  • YES
  • NO

#267

caf_naming_test

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 16, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@arnaudlh arnaudlh self-requested a review January 16, 2024 07:47
@arnaudlh arnaudlh added the enhancement New feature or request label Jan 16, 2024
@arnaudlh arnaudlh added this to the 1.2.27 milestone Jan 16, 2024
@arnaudlh arnaudlh changed the title added naming convention support for search service module Added naming convention support for search service module Jan 16, 2024
arnaudlh
arnaudlh approved these changes Jan 16, 2024
View reviewed changes
Copy link
Member

@arnaudlh arnaudlh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arnaudlh arnaudlh merged commit d596897 into aztfmod:main Jan 16, 2024
2 checks passed
@arnaudlh arnaudlh linked an issue Jan 16, 2024 that may be closed by this pull request
Naming convention method for a new module- Azure cognitive search service #267
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arnaudlh arnaudlh arnaudlh approved these changes

Assignees

@leelasatyavathip leelasatyavathip

Labels
enhancement New feature or request
Projects
2401
Status: Done
Milestone
1.2.27
Development

Successfully merging this pull request may close these issues.

Naming convention method for a new module- Azure cognitive search service
2 participants
@leelasatyavathip @arnaudlh