[AutoPR @azure/arm-domainservices] Renormalize line endings from CRLF to LF

sdk/domainservices/arm-domainservices/CHANGELOG.md

@@ -1,15 +1,25 @@
 # Release History
+
+## 5.0.0 (2023-08-09)
+
+**Features**
 
-## 4.1.1 (Unreleased)
-
-### Features Added
-
-### Breaking Changes
-
-### Bugs Fixed
+  - Added Type Alias ChannelBinding
+  - Added Type Alias LdapSigning
+  - Added Type Alias SyncScope
+  - Interface DomainSecuritySettings has a new optional parameter channelBinding
+  - Interface DomainSecuritySettings has a new optional parameter ldapSigning
+  - Interface DomainService has a new optional parameter syncApplicationId
+  - Interface DomainService has a new optional parameter syncScope
+  - Added Enum KnownChannelBinding
+  - Added Enum KnownLdapSigning
+  - Added Enum KnownSyncScope
 
-### Other Changes
+**Breaking Changes**
 
+  - Class DomainServicesResourceProvider has a new signature
+
+
 ## 4.1.0 (2022-11-22)
 
 **Features**

sdk/domainservices/arm-domainservices/LICENSE

@@ -1,6 +1,6 @@
 The MIT License (MIT)
 
-Copyright (c) 2022 Microsoft
+Copyright (c) 2023 Microsoft
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal

sdk/domainservices/arm-domainservices/_meta.json

@@ -1,8 +1,8 @@
 {
-  "commit": "1f1d5b0b9ce6cc94605b2fd619dce374fb6e033a",
-  "readme": "specification\\domainservices\\resource-manager\\readme.md",
-  "autorest_command": "autorest --version=3.8.4 --typescript --modelerfour.lenient-model-deduplication --azure-arm --head-as-boolean=true --license-header=MICROSOFT_MIT_NO_VERSION --generate-test --typescript-sdks-folder=D:\\Git\\azure-sdk-for-js ..\\azure-rest-api-specs\\specification\\domainservices\\resource-manager\\readme.md --use=@autorest/typescript@6.0.0-rc.3.20221108.1  --generate-sample=true",
+  "commit": "4d0de992bd7359a53502aff4fddf297e26f86916",
+  "readme": "specification/domainservices/resource-manager/readme.md",
+  "autorest_command": "autorest --version=3.9.3 --typescript --modelerfour.lenient-model-deduplication --azure-arm --head-as-boolean=true --license-header=MICROSOFT_MIT_NO_VERSION --generate-test --typescript-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-js ../azure-rest-api-specs/specification/domainservices/resource-manager/readme.md --use=@autorest/typescript@^6.0.4",
   "repository_url": "https://github.com/Azure/azure-rest-api-specs.git",
-  "release_tool": "@azure-tools/js-sdk-release-tools@2.4.2",
-  "use": "@autorest/typescript@6.0.0-rc.3.20221108.1"
+  "release_tool": "@azure-tools/js-sdk-release-tools@2.7.1",
+  "use": "@autorest/typescript@^6.0.4"
 }

sdk/domainservices/arm-domainservices/package.json

@@ -3,15 +3,15 @@
   "sdk-type": "mgmt",
   "author": "Microsoft Corporation",
   "description": "A generated SDK for DomainServicesResourceProvider.",
-  "version": "4.1.1",
+  "version": "5.0.0",
   "engines": {
     "node": ">=14.0.0"
   },
   "dependencies": {
-    "@azure/core-lro": "^2.2.0",
+    "@azure/core-lro": "^2.5.4",
     "@azure/abort-controller": "^1.0.0",
     "@azure/core-paging": "^1.2.0",
-    "@azure/core-client": "^1.6.1",
+    "@azure/core-client": "^1.7.0",
     "@azure/core-auth": "^1.3.0",
     "@azure/core-rest-pipeline": "^1.8.0",
     "tslib": "^2.2.0"
@@ -33,12 +33,13 @@
     "@rollup/plugin-json": "^6.0.0",
     "@rollup/plugin-multi-entry": "^6.0.0",
     "@rollup/plugin-node-resolve": "^13.1.3",
-    "mkdirp": "^1.0.4",
+    "mkdirp": "^2.1.2",
     "rollup": "^2.66.1",
     "rollup-plugin-sourcemaps": "^0.6.3",
     "typescript": "~5.0.0",
     "uglify-js": "^3.4.9",
     "rimraf": "^3.0.0",
+    "dotenv": "^16.0.0",
     "@azure/identity": "^2.0.1",
     "@azure-tools/test-recorder": "^3.0.0",
     "@azure-tools/test-credential": "^1.0.0",
@@ -49,7 +50,6 @@
     "@types/node": "^14.0.0",
     "@azure/dev-tool": "^1.0.0"
   },
-  "homepage": "https://github.com/Azure/azure-sdk-for-js/tree/main/sdk/domainservices/arm-domainservices",
   "repository": {
     "type": "git",
     "url": "https://github.com/Azure/azure-sdk-for-js.git"
@@ -111,12 +111,5 @@
     ]
   },
   "autoPublish": true,
-  "//sampleConfiguration": {
-    "productName": "",
-    "productSlugs": [
-      "azure"
-    ],
-    "disableDocsMs": true,
-    "apiRefLink": "https://docs.microsoft.com/javascript/api/@azure/arm-domainservices?view=azure-node-preview"
-  }
-}
+  "homepage": "https://github.com/Azure/azure-sdk-for-js/tree/main/sdk/domainservices/arm-domainservices"
+}

sdk/domainservices/arm-domainservices/review/arm-domainservices.api.md

@@ -6,9 +6,12 @@
 
 import * as coreAuth from '@azure/core-auth';
 import * as coreClient from '@azure/core-client';
+import { OperationState } from '@azure/core-lro';
 import { PagedAsyncIterableIterator } from '@azure/core-paging';
-import { PollerLike } from '@azure/core-lro';
-import { PollOperationState } from '@azure/core-lro';
+import { SimplePollerLike } from '@azure/core-lro';
+
+// @public
+export type ChannelBinding = string;
 
 // @public
 export interface CloudError {
@@ -55,8 +58,10 @@ export type CreatedByType = string;
 
 // @public
 export interface DomainSecuritySettings {
+    channelBinding?: ChannelBinding;
     kerberosArmoring?: KerberosArmoring;
     kerberosRc4Encryption?: KerberosRc4Encryption;
+    ldapSigning?: LdapSigning;
     ntlmV1?: NtlmV1;
     syncKerberosPasswords?: SyncKerberosPasswords;
     syncNtlmPasswords?: SyncNtlmPasswords;
@@ -79,7 +84,9 @@ export interface DomainService extends Resource {
     replicaSets?: ReplicaSet[];
     resourceForestSettings?: ResourceForestSettings;
     sku?: string;
+    readonly syncApplicationId?: string;
     readonly syncOwner?: string;
+    syncScope?: SyncScope;
     readonly tenantId?: string;
     readonly version?: number;
 }
@@ -111,11 +118,11 @@ export type DomainServiceOperationsListResponse = OperationEntityListResult;
 
 // @public
 export interface DomainServices {
-    beginCreateOrUpdate(resourceGroupName: string, domainServiceName: string, domainService: DomainService, options?: DomainServicesCreateOrUpdateOptionalParams): Promise<PollerLike<PollOperationState<DomainServicesCreateOrUpdateResponse>, DomainServicesCreateOrUpdateResponse>>;
+    beginCreateOrUpdate(resourceGroupName: string, domainServiceName: string, domainService: DomainService, options?: DomainServicesCreateOrUpdateOptionalParams): Promise<SimplePollerLike<OperationState<DomainServicesCreateOrUpdateResponse>, DomainServicesCreateOrUpdateResponse>>;
     beginCreateOrUpdateAndWait(resourceGroupName: string, domainServiceName: string, domainService: DomainService, options?: DomainServicesCreateOrUpdateOptionalParams): Promise<DomainServicesCreateOrUpdateResponse>;
-    beginDelete(resourceGroupName: string, domainServiceName: string, options?: DomainServicesDeleteOptionalParams): Promise<PollerLike<PollOperationState<void>, void>>;
+    beginDelete(resourceGroupName: string, domainServiceName: string, options?: DomainServicesDeleteOptionalParams): Promise<SimplePollerLike<OperationState<void>, void>>;
     beginDeleteAndWait(resourceGroupName: string, domainServiceName: string, options?: DomainServicesDeleteOptionalParams): Promise<void>;
-    beginUpdate(resourceGroupName: string, domainServiceName: string, domainService: DomainService, options?: DomainServicesUpdateOptionalParams): Promise<PollerLike<PollOperationState<DomainServicesUpdateResponse>, DomainServicesUpdateResponse>>;
+    beginUpdate(resourceGroupName: string, domainServiceName: string, domainService: DomainService, options?: DomainServicesUpdateOptionalParams): Promise<SimplePollerLike<OperationState<DomainServicesUpdateResponse>, DomainServicesUpdateResponse>>;
     beginUpdateAndWait(resourceGroupName: string, domainServiceName: string, domainService: DomainService, options?: DomainServicesUpdateOptionalParams): Promise<DomainServicesUpdateResponse>;
     get(resourceGroupName: string, domainServiceName: string, options?: DomainServicesGetOptionalParams): Promise<DomainServicesGetResponse>;
     list(options?: DomainServicesListOptionalParams): PagedAsyncIterableIterator<DomainService>;
@@ -177,6 +184,7 @@ export class DomainServicesResourceProvider extends coreClient.ServiceClient {
     // (undocumented)
     $host: string;
     constructor(credentials: coreAuth.TokenCredential, subscriptionId: string, options?: DomainServicesResourceProviderOptionalParams);
+    constructor(credentials: coreAuth.TokenCredential, options?: DomainServicesResourceProviderOptionalParams);
     // (undocumented)
     apiVersion: string;
     // (undocumented)
@@ -188,7 +196,7 @@ export class DomainServicesResourceProvider extends coreClient.ServiceClient {
     // (undocumented)
     ouContainerOperations: OuContainerOperations;
     // (undocumented)
-    subscriptionId: string;
+    subscriptionId?: string;
 }
 
 // @public
@@ -249,6 +257,12 @@ export type KerberosArmoring = string;
 // @public
 export type KerberosRc4Encryption = string;
 
+// @public
+export enum KnownChannelBinding {
+    Disabled = "Disabled",
+    Enabled = "Enabled"
+}
+
 // @public
 export enum KnownCreatedByType {
     Application = "Application",
@@ -287,6 +301,12 @@ export enum KnownLdaps {
     Enabled = "Enabled"
 }
 
+// @public
+export enum KnownLdapSigning {
+    Disabled = "Disabled",
+    Enabled = "Enabled"
+}
+
 // @public
 export enum KnownNotifyDcAdmins {
     Disabled = "Disabled",
@@ -333,6 +353,12 @@ export enum KnownSyncOnPremPasswords {
     Enabled = "Enabled"
 }
 
+// @public
+export enum KnownSyncScope {
+    All = "All",
+    CloudOnly = "CloudOnly"
+}
+
 // @public
 export enum KnownTlsV1 {
     Disabled = "Disabled",
@@ -342,6 +368,9 @@ export enum KnownTlsV1 {
 // @public
 export type Ldaps = string;
 
+// @public
+export type LdapSigning = string;
+
 // @public
 export interface LdapsSettings {
     readonly certificateNotAfter?: Date;
@@ -459,11 +488,11 @@ export interface OuContainerListResult {
 
 // @public
 export interface OuContainerOperationGrp {
-    beginCreate(resourceGroupName: string, domainServiceName: string, ouContainerName: string, containerAccount: ContainerAccount, options?: OuContainerCreateOptionalParams): Promise<PollerLike<PollOperationState<OuContainerCreateResponse>, OuContainerCreateResponse>>;
+    beginCreate(resourceGroupName: string, domainServiceName: string, ouContainerName: string, containerAccount: ContainerAccount, options?: OuContainerCreateOptionalParams): Promise<SimplePollerLike<OperationState<OuContainerCreateResponse>, OuContainerCreateResponse>>;
     beginCreateAndWait(resourceGroupName: string, domainServiceName: string, ouContainerName: string, containerAccount: ContainerAccount, options?: OuContainerCreateOptionalParams): Promise<OuContainerCreateResponse>;
-    beginDelete(resourceGroupName: string, domainServiceName: string, ouContainerName: string, options?: OuContainerDeleteOptionalParams): Promise<PollerLike<PollOperationState<void>, void>>;
+    beginDelete(resourceGroupName: string, domainServiceName: string, ouContainerName: string, options?: OuContainerDeleteOptionalParams): Promise<SimplePollerLike<OperationState<void>, void>>;
     beginDeleteAndWait(resourceGroupName: string, domainServiceName: string, ouContainerName: string, options?: OuContainerDeleteOptionalParams): Promise<void>;
-    beginUpdate(resourceGroupName: string, domainServiceName: string, ouContainerName: string, containerAccount: ContainerAccount, options?: OuContainerUpdateOptionalParams): Promise<PollerLike<PollOperationState<OuContainerUpdateResponse>, OuContainerUpdateResponse>>;
+    beginUpdate(resourceGroupName: string, domainServiceName: string, ouContainerName: string, containerAccount: ContainerAccount, options?: OuContainerUpdateOptionalParams): Promise<SimplePollerLike<OperationState<OuContainerUpdateResponse>, OuContainerUpdateResponse>>;
     beginUpdateAndWait(resourceGroupName: string, domainServiceName: string, ouContainerName: string, containerAccount: ContainerAccount, options?: OuContainerUpdateOptionalParams): Promise<OuContainerUpdateResponse>;
     get(resourceGroupName: string, domainServiceName: string, ouContainerName: string, options?: OuContainerGetOptionalParams): Promise<OuContainerGetResponse>;
     list(resourceGroupName: string, domainServiceName: string, options?: OuContainerListOptionalParams): PagedAsyncIterableIterator<OuContainer>;
@@ -542,6 +571,9 @@ export type SyncNtlmPasswords = string;
 // @public
 export type SyncOnPremPasswords = string;
 
+// @public
+export type SyncScope = string;
+
 // @public
 export interface SystemData {
     createdAt?: Date;

sdk/domainservices/arm-domainservices/src/domainServicesResourceProvider.ts

@@ -31,7 +31,7 @@ import { DomainServicesResourceProviderOptionalParams } from "./models";
 export class DomainServicesResourceProvider extends coreClient.ServiceClient {
   $host: string;
   apiVersion: string;
-  subscriptionId: string;
+  subscriptionId?: string;
 
   /**
    * Initializes a new instance of the DomainServicesResourceProvider class.
@@ -44,12 +44,28 @@ export class DomainServicesResourceProvider extends coreClient.ServiceClient {
     credentials: coreAuth.TokenCredential,
     subscriptionId: string,
     options?: DomainServicesResourceProviderOptionalParams
+  );
+  constructor(
+    credentials: coreAuth.TokenCredential,
+    options?: DomainServicesResourceProviderOptionalParams
+  );
+  constructor(
+    credentials: coreAuth.TokenCredential,
+    subscriptionIdOrOptions?:
+      | DomainServicesResourceProviderOptionalParams
+      | string,
+    options?: DomainServicesResourceProviderOptionalParams
   ) {
     if (credentials === undefined) {
       throw new Error("'credentials' cannot be null");
     }
-    if (subscriptionId === undefined) {
-      throw new Error("'subscriptionId' cannot be null");
+
+    let subscriptionId: string | undefined;
+
+    if (typeof subscriptionIdOrOptions === "string") {
+      subscriptionId = subscriptionIdOrOptions;
+    } else if (typeof subscriptionIdOrOptions === "object") {
+      options = subscriptionIdOrOptions;
     }
 
     // Initializing default values for options
@@ -61,7 +77,7 @@ export class DomainServicesResourceProvider extends coreClient.ServiceClient {
       credential: credentials
     };
 
-    const packageDetails = `azsdk-js-arm-domainservices/4.1.1`;
+    const packageDetails = `azsdk-js-arm-domainservices/5.0.0`;
     const userAgentPrefix =
       options.userAgentOptions && options.userAgentOptions.userAgentPrefix
         ? `${options.userAgentOptions.userAgentPrefix} ${packageDetails}`
@@ -114,7 +130,7 @@ export class DomainServicesResourceProvider extends coreClient.ServiceClient {
 
     // Assigning values to Constant parameters
     this.$host = options.$host || "https://management.azure.com";
-    this.apiVersion = options.apiVersion || "2021-05-01";
+    this.apiVersion = options.apiVersion || "2022-12-01";
     this.domainServiceOperations = new DomainServiceOperationsImpl(this);
     this.domainServices = new DomainServicesImpl(this);
     this.ouContainerOperations = new OuContainerOperationsImpl(this);

sdk/domainservices/arm-domainservices/src/lroImpl.ts

@@ -6,29 +6,37 @@
  * Changes may cause incorrect behavior and will be lost if the code is regenerated.
  */
 
+// Copyright (c) Microsoft Corporation.
+// Licensed under the MIT license.
+
+import { AbortSignalLike } from "@azure/abort-controller";
 import { LongRunningOperation, LroResponse } from "@azure/core-lro";
 
-export class LroImpl<T> implements LongRunningOperation<T> {
-  constructor(
-    private sendOperationFn: (args: any, spec: any) => Promise<LroResponse<T>>,
-    private args: Record<string, unknown>,
-    private spec: {
-      readonly requestBody?: unknown;
-      readonly path?: string;
-      readonly httpMethod: string;
-    } & Record<string, any>,
-    public requestPath: string = spec.path!,
-    public requestMethod: string = spec.httpMethod
-  ) {}
-  public async sendInitialRequest(): Promise<LroResponse<T>> {
-    return this.sendOperationFn(this.args, this.spec);
-  }
-  public async sendPollRequest(path: string): Promise<LroResponse<T>> {
-    const { requestBody, ...restSpec } = this.spec;
-    return this.sendOperationFn(this.args, {
-      ...restSpec,
-      path,
-      httpMethod: "GET"
-    });
-  }
+export function createLroSpec<T>(inputs: {
+  sendOperationFn: (args: any, spec: any) => Promise<LroResponse<T>>;
+  args: Record<string, unknown>;
+  spec: {
+    readonly requestBody?: unknown;
+    readonly path?: string;
+    readonly httpMethod: string;
+  } & Record<string, any>;
+}): LongRunningOperation<T> {
+  const { args, spec, sendOperationFn } = inputs;
+  return {
+    requestMethod: spec.httpMethod,
+    requestPath: spec.path!,
+    sendInitialRequest: () => sendOperationFn(args, spec),
+    sendPollRequest: (
+      path: string,
+      options?: { abortSignal?: AbortSignalLike }
+    ) => {
+      const { requestBody, ...restSpec } = spec;
+      return sendOperationFn(args, {
+        ...restSpec,
+        httpMethod: "GET",
+        path,
+        abortSignal: options?.abortSignal
+      });
+    }
+  };
 }