fix: allow relative imports within a package

azz · Dec 14, 2017 · 8669e77 · 8669e77
1 parent 592a7e1
commit 8669e77
Show file tree

Hide file tree

Showing 3 changed files with 933 additions and 27 deletions.
diff --git a/package.json b/package.json
@@ -41,6 +41,7 @@
     "eslint-module-utils": "^2.1.1",
     "globby": "^7.1.1",
     "load-json-file": "^4.0.0",
+    "minimatch": "^3.0.4",
     "parse-package-name": "^0.1.0",
     "path-is-inside": "^1.0.2"
   }

diff --git a/src/rules/no-relative-import.js b/src/rules/no-relative-import.js
@@ -3,6 +3,7 @@ import moduleVisitor, {
   makeOptionsSchema,
 } from 'eslint-module-utils/moduleVisitor';
 import isInside from 'path-is-inside';
+import minimatch from 'minimatch';
 import path from 'path';
 import getPackages from '../get-packages';
 
@@ -18,8 +19,9 @@ export const create = context => {
 
   return moduleVisitor(node => {
     const resolvedPath = resolve(node.value, context);
+    const packageDir = getPackageDir(sourceFsPath, packages);
 
-    if (!resolvedPath || isInside(resolvedPath, path.dirname(sourceFsPath))) {
+    if (!packageDir || !resolvedPath || isInside(resolvedPath, packageDir)) {
       return;
     }
 
@@ -41,3 +43,12 @@ export const create = context => {
     }
   }, moduleUtilOptions);
 };
+
+const getPackageDir = (filePath, packages) => {
+  const match = packages.find(pkg =>
+    minimatch(filePath, path.join(pkg.fsPath, '**'))
+  );
+  if (match) {
+    return match.fsPath;
+  }
+};