Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onboarding middleware conflict resolve #24

Conversation

poorphd
Copy link

@poorphd poorphd commented Aug 2, 2023

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • included the necessary unit and integration tests
  • reviewed "Files changed" and left comments if necessary

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

poorphd and others added 21 commits July 26, 2023 17:43
…ecovery-module

feat: remove recovery module
feat: CI/CD workflow and Cosmos-sdk simulation
…leware-conflict-resolve

# Conflicts:
#	app/app.go
#	x/recovery/keeper/ibc_callbacks.go
#	x/recovery/keeper/ibc_callbacks_integration_suite_test.go

(cherry picked from commit 4d45df7)
…re-conflict-resolve

# Conflicts:
#	app/app.go
#	app/app_test.go
#	app/test_helpers.go

(cherry picked from commit ec76588)
(cherry picked from commit 5ac28de)
@dongsam dongsam force-pushed the onboarding-middleware-conflict-resolve branch from ba5685f to 6626290 Compare August 3, 2023 08:08
…ng-middleware-conflict-resolve

* commit 'd780d52648475e8887cacce73acec93ae59fb34b':
  chore: add branches rule for workflow
  fix: simulation seed randomness was removed to make the ci/cd result deterministic
  fix: remove recovery from storeKeysPrefixes
  add placeholder for ICS4wrapper in transferKeeper init
  remove recovery imports in app.go
  remove recovery proto
  remove x/recovery
  fix: update simulation target modules, refactor duplicated struct
  fix: removing unused keeper from handler options
  fix: simulation workflow, update sims.yml, add GOPATH on makefile
  fix: simulation errors
  fix: seperate antehandler for simulation
  feat: add workflow to build, test, codecov for ci/cd

# Conflicts:
#	app/app.go
#	app/test_helpers.go
#	proto/canto/onboarding/v1/query.proto
#	x/onboarding/client/cli/query.go
#	x/onboarding/genesis.go
#	x/onboarding/genesis_test.go
#	x/onboarding/ibc_middleware.go
#	x/onboarding/keeper/grpc_query.go
#	x/onboarding/keeper/grpc_query_test.go
#	x/onboarding/keeper/keeper.go
#	x/onboarding/keeper/keeper_test.go
#	x/onboarding/keeper/params.go
#	x/onboarding/keeper/utils_test.go
#	x/onboarding/module.go
#	x/onboarding/types/errors.go
#	x/onboarding/types/genesis.go
#	x/onboarding/types/genesis.pb.go
#	x/onboarding/types/genesis_test.go
#	x/onboarding/types/keys.go
#	x/onboarding/types/params_test.go
#	x/onboarding/types/query.pb.go
#	x/onboarding/types/query.pb.gw.go
@dongsam dongsam closed this Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants