Generate AngleSharp based on included AngleSharp version #1286
Conversation
egil
force-pushed
the
anglesharp-gen
branch
2 times, most recently
from
65bab58
to
3494b04
Compare
...nit.web.anglesharp.tests/WrapperElementsGeneratorTest.Generator#ElementWrapper.g.verified.cs
Outdated
Show resolved
Hide resolved
|
Samples and or docs probably have to be adapted as well |
…r target, additional attributes on generated types
working on it. docs was not set to build against .net 8. |
…generated correctly
|
@linkdotnet improved the generator quite a bit. Want to take a second look at it? |
Will check it out tomorrow and fetch the branch to play aroud |
|
There is technically a breaking change. The old wrapper types were public, the new ones are internal. I am tempted to disregard this as I've always considered the wrappers a pubternal thing. Whats your take? |
Have a similar opinion - while they were public, we never directly exposed them. The code always returned an |
|
|
||
| var elementInterfacetypes = FindElementInterfaces(angleSharpAssembly); | ||
|
|
||
| var source = new StringBuilder(); |
There was a problem hiding this comment.
Small perf optimization: Initialize with a pre-allocated buffer.
| var source = new StringBuilder(); | |
| var source = new StringBuilder(2000); |
|
Really nice work - an initial build is "noticeable" slower now - but I am not sure if there as much you can do. |
| public TElement WrappedElement | ||
| { | ||
| [MethodImpl(MethodImplOptions.AggressiveInlining)] | ||
| get |
There was a problem hiding this comment.
The whole get can be simplfiied to:
get => element ??= elementFactory.GetElement<TElement>();
Pull request description
This replaces AngleSharpWrappers with similar types that are generated using a source generator project. This allows us to easily upgrade AngleSharp and have new public members supported by the wrappers.
This uses Verify to snapshot test the generated wrappers.
This also upgrades AngleSharp to latest versions. Eventhough AngleSharp.Css I a preview release, it should be safe to use, according to AngleSharp/AngleSharp.Css#150.
The downside is that the generators adds a little to the build time. They should only run one time, as far as I can tell, but we may need to optimize on this.
It also changes the
IElementFactorytype and makes the wrappers easier to work with, something relevant with #1252.