Merge pull request #50 from ba-st/series-in-packages

Series in packages

.github/workflows/build.yml

@@ -7,20 +7,21 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        smalltalk: [ Pharo64-8.0, Pharo64-7.0, Pharo32-7.0, Pharo32-6.1 ]
+        smalltalk: [ Pharo64-8.0, Pharo64-7.0, Pharo32-7.0 ]
     name: ${{ matrix.smalltalk }}
     steps:
       - uses: actions/checkout@v2
-      - uses: ba-st-actions/setup-smalltalkCI@v1.0.0
+      - uses: hpi-swa/setup-smalltalkCI@v1
         with:
           smalltalk-version: ${{ matrix.smalltalk }}
-      - run: smalltalkci -s ${{ matrix.smalltalk }}
-        timeout-minutes: 60
+      - name: Load Image and Run Tests
+        run: smalltalkci -s ${{ matrix.smalltalk }}
         env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
           SMALLTALK_CI_TIMEOUT: 50
-      - run: echo "::set-env name=SCI_COVERAGE_FILE_LOCATION::${HOME}/.smalltalkCI/_builds/coveralls_results.json"
+        timeout-minutes: 60
       - name: Upload coverage to Codecov
-        uses: codecov/codecov-action@v1.0.6
+        uses: codecov/codecov-action@v1
         with:
+          name: ${{matrix.smalltalk}}
           token: ${{ secrets.CODECOV_TOKEN }}
-          file: ${{ env.SCI_COVERAGE_FILE_LOCATION }}

.smalltalk.ston

@@ -9,7 +9,8 @@ SmalltalkCISpec {
   ],
   #testing : {
     #coverage : {
-       #packages : [ 'HighchartsSt*' , 'HighstockSt*' ]
+      #packages : [ 'HighchartsSt*' , 'HighstockSt*' ],
+      #format: #lcov
     }
   }
 }

import-tool/README.md

@@ -11,11 +11,23 @@
 ```
 4. Copy from the terminal output the file library import code.
 5. Download the latest released image and open it in Pharo.
-6. Since the current import tool does not delete old tests (it does not remove methods testing protocol that no longer exists respect to a previous version, nor deletes test classes for components that no longer exist), you should remove all test classes and methods for the Highcharts and Highstock packages.
-7. Open a Playground and evaluate (updating the path)
+6. Since the current import tool does not delete
+ old tests (it does not remove methods testing protocol
+  that no longer exists respect to a previous version,
+  nor deletes test classes for components that no longer exist),
+   you should remove all test classes and methods for the
+   Highcharts and Highstock packages.
+6. The current import tool does not yet create classes for series in their respective packages by default. You need to manually delete all series packages before running the import process (to avoid keeping classes or method that no longer exist).
+7. The current import tool does not delete old tests (it does not remove methods testing protocol that no longer exists respect to a previous version, nor deletes test classes for components that no longer exist), you should remove all test packages named Highcharts-V...-Tests and Highstock-V...-Tests.
+8. Open a Playground and evaluate (updating the path)
 ```smalltalk
 (Highsoft8ImportTool importingFrom: '/path/to/api/API.json') execute
 ```
-8. Update the version in the library classes (some are on the instance side, others on the class side).
-9. Import the libraries code using the previously copied terminal output.
-10. Commit the changes.
+9. Move the series classes to their respect classes by evaluating:
+```smalltalk
+SeriesToPackagesProcess onHighcharts executeMove; compilePackageSpecInBaseline.
+SeriesToPackagesProcess onHighstock executeMove; compilePackageSpecInBaseline.
+```
+10. Update the version in the library classes (some are on the instance side, others on the class side).
+11. Import the libraries code using the previously copied terminal output.
+12. Commit the changes.