Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eoi service #327

Merged
merged 6 commits into from
Nov 11, 2024
Merged

Eoi service #327

merged 6 commits into from
Nov 11, 2024

Conversation

jrwbabylonlab
Copy link
Collaborator

No description provided.

SEND_BBN = "send_bbn",
}

export const useEoiCreationService = () => {
Copy link
Collaborator Author

@jrwbabylonlab jrwbabylonlab Nov 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I decided not to spend more time refectories this giant method as I feel like this shall be moved to either btc-staking-ts or a SDK repo
fyi @totraev @gbarkhatov

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay

// Invalidate UTXOs
queryClient.invalidateQueries({ queryKey: [UTXO_KEY, address] });
};
await createDelegationEoi(eoiInput, signingCallback);
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gbarkhatov after this line of execution, we shall start showing the modal of loading the verify state of a delegation

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay.
Should we add a TODO in the code? as it was above

const handleSign = async () => {
// TODO: To hook up with the react signing modal
const signingCallback = async (step: SigningStep) => {
console.log("Signing step:", step);
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gbarkhatov this is the placeholder method in which you can use for the signing modal to step through each signing steps.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

@jrwbabylonlab jrwbabylonlab mentioned this pull request Nov 11, 2024
const handleSign = async () => {
// TODO: To hook up with the react signing modal
const signingCallback = async (step: SigningStep) => {
console.log("Signing step:", step);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

// Invalidate UTXOs
queryClient.invalidateQueries({ queryKey: [UTXO_KEY, address] });
};
await createDelegationEoi(eoiInput, signingCallback);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay.
Should we add a TODO in the code? as it was above

src/app/components/Staking/Staking.tsx Show resolved Hide resolved
SEND_BBN = "send_bbn",
}

export const useEoiCreationService = () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay

};

/**
* Extracts the first valid Schnorr signature from a signed transaction.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will the "first valid schnorr signature" work every time?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, i think this is how signing sig works for taproots.
@gitferry can correct me if i'm wrong. the babylon side is also doing this

@jrwbabylonlab jrwbabylonlab merged commit fe0e242 into main Nov 11, 2024
1 check passed
@jrwbabylonlab jrwbabylonlab deleted the eoi-service branch November 11, 2024 09:49
@jrwbabylonlab jrwbabylonlab restored the eoi-service branch November 11, 2024 13:41
@jrwbabylonlab jrwbabylonlab deleted the eoi-service branch November 11, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants