-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eoi service #327
Eoi service #327
Conversation
SEND_BBN = "send_bbn", | ||
} | ||
|
||
export const useEoiCreationService = () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I decided not to spend more time refectories this giant method as I feel like this shall be moved to either btc-staking-ts or a SDK repo
fyi @totraev @gbarkhatov
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay
// Invalidate UTXOs | ||
queryClient.invalidateQueries({ queryKey: [UTXO_KEY, address] }); | ||
}; | ||
await createDelegationEoi(eoiInput, signingCallback); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gbarkhatov after this line of execution, we shall start showing the modal of loading the verify state of a delegation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay.
Should we add a TODO in the code? as it was above
const handleSign = async () => { | ||
// TODO: To hook up with the react signing modal | ||
const signingCallback = async (step: SigningStep) => { | ||
console.log("Signing step:", step); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gbarkhatov this is the placeholder method in which you can use for the signing modal to step through each signing steps.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok
const handleSign = async () => { | ||
// TODO: To hook up with the react signing modal | ||
const signingCallback = async (step: SigningStep) => { | ||
console.log("Signing step:", step); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok
// Invalidate UTXOs | ||
queryClient.invalidateQueries({ queryKey: [UTXO_KEY, address] }); | ||
}; | ||
await createDelegationEoi(eoiInput, signingCallback); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay.
Should we add a TODO in the code? as it was above
SEND_BBN = "send_bbn", | ||
} | ||
|
||
export const useEoiCreationService = () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay
}; | ||
|
||
/** | ||
* Extracts the first valid Schnorr signature from a signed transaction. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will the "first valid schnorr signature" work every time?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, i think this is how signing sig works for taproots.
@gitferry can correct me if i'm wrong. the babylon side is also doing this
No description provided.