fix: OKX signature tweak signer #364
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbarkhatov
requested review from
vitsalis,
totraev,
jrwbabylonlab and
jeremy-babylonlabs
totraev
previously approved these changes
Nov 18, 2024
vitsalis
requested changes
Nov 18, 2024
| { | ||
| toSignInputs: [ | ||
| { | ||
| index: 0, |
There was a problem hiding this comment.
This looks hacky. signPsbt is being used to not only sign transactions with a single input. Also, what if the input is not a taproot one?
There was a problem hiding this comment.
Agree, but it's not failing to sign the psbt
We can do a list with options in src/app/common/utils/psbt.ts. This signPsbtTransaction is used only in Unbonding and Withdrawing
So if it's OKX and we are unbonding or withdrawing, we can pass the boolean flag
Based on that flag OKX will check whether the wallet is on Taproot, and if so - add the needed options
Another solution is for OKX to disable the changes, but question is what is more future-proof?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes OKX
3.29.26versiondisableTweakSigner