Allow specifying files to download in HuggingfaceVolume #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpnowacki-reef
requested changes
Jan 27, 2025
| @@ -23,8 +23,10 @@ def __str__(self): | |||
| class HuggingfaceVolume(pydantic.BaseModel): | |||
| volume_type: Literal[VolumeType.huggingface_volume] = VolumeType.huggingface_volume | |||
| repo_id: str | |||
| repo_type: str | None = None | |||
There was a problem hiding this comment.
i think it should be explained what values go in here, either with a comment or a Literal.... kind of thing
| revision: str | None = None # Git revision id: branch name / tag / commit hash | ||
| relative_path: str | None = None | ||
| allow_patterns: str | list[str] | None = None |
There was a problem hiding this comment.
an explanation would be very useful
slawomir-gorawski-reef
force-pushed
the
huggingface-volume-files
branch
3 times, most recently
from
697bfc8 to
6af15f3
Compare
slawomir-gorawski-reef
force-pushed
the
huggingface-volume-files
branch
from
6af15f3 to
1e38772
Compare
mpnowacki-reef
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For SN21 integration we want to be able download some files from a huge dataset repo without having to download the entire repository. I added two things to make it possible:
repo_type: must be"dataset"for dataset repositories, otherwise it doesn't work. Can be left asNonefor our current usage (models).allow_patterns: this is passed as-is to the hugginface_hub function. I use it to specify the list of files that I need, but I left the original signature (str | list[str]) because we might want to specify a single pattern at some point, I saw something like that in the SDK design issue.