Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: spring security whitelist filtering #20

Merged
merged 6 commits into from
Mar 13, 2024
Merged

feat: spring security whitelist filtering #20

merged 6 commits into from
Mar 13, 2024

Conversation

ghkdqhrbals
Copy link
Member

@ghkdqhrbals ghkdqhrbals commented Mar 12, 2024 •
edited
Loading

Implements

  • HttpServletRequest null check before whitelist bypassing
  • Change JwtAuthFilter test by adding mock HttpServlet request/response
  • Add whiteList constants

@ghkdqhrbals ghkdqhrbals self-assigned this Mar 12, 2024
@ghkdqhrbals ghkdqhrbals requested a review from LeeJeongGi March 12, 2024 08:39
@github-actions GitHub Actions
Copy link

📝 Test code-coverage reports

File Coverage [73.33%] 🍏
URLConsts.java 100% 🍏
JwtAuthFilter.java 66.04% 🍏
Total Project Coverage 90.59% 🍏

@ghkdqhrbals ghkdqhrbals linked an issue Mar 12, 2024 that may be closed by this pull request
feat: url whitelist check filter #19
Closed
LeeJeongGi
LeeJeongGi approved these changes Mar 12, 2024
View reviewed changes
Copy link
Member

@LeeJeongGi LeeJeongGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

인증 추가 구현하시느라 수고하셨습니다! :)

bm-controller/src/main/java/org/benchmarker/security/JwtAuthFilter.java Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

📝 Test code-coverage reports

File Coverage [75.2%] 🍏
URLConsts.java 100% 🍏
JwtAuthFilter.java 67.71% 🍏
Total Project Coverage 90.74% 🍏

@ghkdqhrbals ghkdqhrbals merged commit 8b5477d into develop Mar 13, 2024
1 check passed
@ghkdqhrbals ghkdqhrbals deleted the feature/whitelist-filter branch March 13, 2024 07:59
ghkdqhrbals added a commit that referenced this pull request Mar 17, 2024
@ghkdqhrbals
feat: spring security whitelist filtering (#20)
a7a0cfb 
* dev: whitelist url consts

* dev: whitelist method and url pair class

* dev: security exception remove token cookie & whitelist check

* test: mocking servlet req/resp for authFilter

* dev: request null check before whitelist pass

* dev: remove request null check in filter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeeJeongGi LeeJeongGi LeeJeongGi approved these changes

Assignees

@ghkdqhrbals ghkdqhrbals

Labels
feat
Projects
Benchmark kanbanboard
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: url whitelist check filter
2 participants
@ghkdqhrbals @LeeJeongGi