Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: perf result page #91

Merged
merged 3 commits into from
Apr 17, 2024
Merged

feat: perf result page #91

merged 3 commits into from
Apr 17, 2024

Conversation

ghkdqhrbals
Copy link
Member

Implements

  • Helper class for Integration testing
  • Additional error code
  • TestResult -> CommonResultDto conversion class
  • Performance result page update as below
image

Here, you can toggle agent status to see the current agents status and their cpu usage.

  • By sending commonResult through model, now result page will show the result of the test
image

@ghkdqhrbals ghkdqhrbals requested a review from LeeJeongGi April 13, 2024 10:35
@ghkdqhrbals ghkdqhrbals self-assigned this Apr 13, 2024
@ghkdqhrbals ghkdqhrbals added the feat - enhancement New feature or request label Apr 13, 2024
LeeJeongGi
LeeJeongGi approved these changes Apr 14, 2024
View reviewed changes
Copy link
Member

@LeeJeongGi LeeJeongGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

정말 끝까지 열심히 해주셔서 감사합니다!! :)

(분명 건강검진을 받고 왔는데 몸이 왜 이렇게 안 좋아진건지 모르겠네요;;)

...troller/src/main/java/org/benchmarker/bmcontroller/template/service/utils/ParentTXCheck.java
* @throws IllegalStateException if parent transaction is not active or not exist
*/
public static void IsParentTransactionActive() {
boolean actualTransactionActive = TransactionSynchronizationManager.isActualTransactionActive();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

스프링에선 트렌젝션을 계층 구조로 관리한다는 것과 부모의 트렌잭션 활성화 여부를 판별 할 수 있는 것도 처음알았네요 !! 👍

...roller/src/test/java/org/benchmarker/bmcontroller/preftest/helper/IntegrationTestHelper.java

TestStatus defaultTestStatus = TestStatusHelper.createDefaultTestStatus();
defaultTestStatus.setTestResult(saveTestResult);
testStatusRepository.save(defaultTestStatus);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

엄청나게 많은 정보를 한번에 저장 하네요.

실제 기업 서비스에는 더 많은 테이블이 있고 관리 해야 할 것이 훨씬 많을텐데 어떻게 저장 하는지 문득 궁금해지네요.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

저도 그게 궁금합니다ㅎㅎ. 아마 메소드로 묶어서 관리하지 않을까 생각합니다!

@ghkdqhrbals ghkdqhrbals merged commit badf258 into develop Apr 17, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeeJeongGi LeeJeongGi LeeJeongGi approved these changes

Assignees

@ghkdqhrbals ghkdqhrbals

Labels
feat - enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ghkdqhrbals @LeeJeongGi