GitHub Discussions Search Collator #1744
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed Packages
|
minkimcello
force-pushed
the
mk/github-discussions
branch
from
91e0ebe
to
0c22eb3
Compare
Signed-off-by: Min Kim <minkimcello@gmail.com>
Signed-off-by: Min Kim <minkimcello@gmail.com>
Signed-off-by: Min Kim <minkimcello@gmail.com>
Signed-off-by: Min Kim <minkimcello@gmail.com>
Signed-off-by: Min Kim <minkimcello@gmail.com>
Signed-off-by: Min Kim <minkimcello@gmail.com>
Signed-off-by: Min Kim <minkimcello@gmail.com>
Signed-off-by: Min Kim <minkimcello@gmail.com>
Signed-off-by: Min Kim <minkimcello@gmail.com>
Signed-off-by: Min Kim <minkimcello@gmail.com>
Signed-off-by: Min Kim <minkimcello@gmail.com>
Signed-off-by: Min Kim <minkimcello@gmail.com>
Signed-off-by: Min Kim <minkimcello@gmail.com>
Signed-off-by: Min Kim <minkimcello@gmail.com>
Co-authored-by: Taras Mankovski <tarasm@gmail.com> Signed-off-by: Min Kim <minkimcello@gmail.com>
Co-authored-by: Taras Mankovski <tarasm@gmail.com> Signed-off-by: Min Kim <minkimcello@gmail.com>
Signed-off-by: Min Kim <minkimcello@gmail.com>
Signed-off-by: Min Kim <minkimcello@gmail.com>
Co-authored-by: Taras Mankovski <taras@frontside.com> Signed-off-by: Min Kim <minkimcello@gmail.com>
Signed-off-by: Min Kim <minkimcello@gmail.com>
Signed-off-by: Min Kim <minkimcello@gmail.com>
Signed-off-by: Min Kim <minkimcello@gmail.com>
Signed-off-by: Min Kim <minkimcello@gmail.com>
Signed-off-by: Min Kim <minkimcello@gmail.com>
Signed-off-by: Min Kim <minkimcello@gmail.com>
Signed-off-by: Min Kim <minkimcello@gmail.com>
Signed-off-by: Min Kim <minkimcello@gmail.com>
Signed-off-by: Min Kim <minkimcello@gmail.com>
Signed-off-by: Min Kim <minkimcello@gmail.com>
Signed-off-by: Min Kim <minkimcello@gmail.com>
Signed-off-by: Min Kim <minkimcello@gmail.com>
Signed-off-by: Min Kim <minkimcello@gmail.com>
Signed-off-by: Min Kim <minkimcello@gmail.com>
Signed-off-by: Min Kim <minkimcello@gmail.com>
Signed-off-by: Min Kim <minkimcello@gmail.com>
Signed-off-by: Min Kim <minkimcello@gmail.com>
Signed-off-by: Min Kim <minkimcello@gmail.com>
Signed-off-by: Min Kim <minkimcello@gmail.com>
Signed-off-by: Min Kim <minkimcello@gmail.com>
Signed-off-by: Min Kim <minkimcello@gmail.com>
minkimcello
force-pushed
the
mk/github-discussions
branch
from
0c22eb3
to
67c86c4
Compare
Signed-off-by: Min Kim <minkimcello@gmail.com>
Signed-off-by: Min Kim <minkimcello@gmail.com>
Co-authored-by: Taras Mankovski <taras@frontside.com> Signed-off-by: Min Kim <minkimcello@gmail.com>
Signed-off-by: Min Kim <minkimcello@gmail.com>
Signed-off-by: Min Kim <minkimcello@gmail.com>
Signed-off-by: Min Kim <minkimcello@gmail.com>
Signed-off-by: Min Kim <minkimcello@gmail.com>
Write tests
minkimcello
requested review from
backstage-service and
a team
as code owners
Signed-off-by: Min Kim <minkimcello@gmail.com>
Signed-off-by: Min Kim <minkimcello@gmail.com>
vinzscam
requested changes
Nov 13, 2024
Comment on lines
+166
to
+173
| assert(url !== null, `Not parsable as a Github URL`); | ||
| const { name: repo, owner: org } = url; | ||
| assert(org !== null, `Discussions url is missing organization name`); | ||
| assert(repo !== null, `Discussion url is missing repository`); | ||
|
|
||
| const integration = this.githubIntegration.byUrl(url.href); | ||
|
|
||
| assert(integration, `Could not retrieve a Github integration for ${url}`); |
There was a problem hiding this comment.
can we do all this checks in fromConfig instead? Is there any specific reason why you are using this assert-ts library instead of just throwing plain errors?
Comment on lines
+194
to
+225
| const task = run(function* injection(): Operation<void> { | ||
| const scope = yield* useScope(); | ||
| const results = createQueue<GithubDiscussionFetcherResult, void>(); | ||
|
|
||
| yield* spawn(function* (): Operation<void> { | ||
| try { | ||
| yield* fetchGithubDiscussions({ | ||
| client, | ||
| org, | ||
| repo, | ||
| discussionsBatchSize, | ||
| commentsBatchSize, | ||
| repliesBatchSize, | ||
| logger, | ||
| results, | ||
| cache, | ||
| timeout, | ||
| clearCacheOnSuccess, | ||
| }); | ||
| } catch (e) { | ||
| logger.log(e); | ||
| logger.error( | ||
| `Encountered an error while ingesting GitHub Discussions`, | ||
| e, | ||
| ); | ||
| } | ||
| results.close(); | ||
| }); | ||
|
|
||
| documents = toAsyncIterable(results, scope); | ||
|
|
||
| yield* suspend(); |
There was a problem hiding this comment.
this isn't a pattern we use in this repository or in the core Backstage. Is it possible to simplifying this using normal promises or native async iterators? Tbh it looks complex and hard to follow
| @@ -0,0 +1,5 @@ | |||
| compressionLevel: mixed | |||
There was a problem hiding this comment.
you can skip this file and the .yarn folder
Signed-off-by: Min Kim <minkimcello@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I just made a Pull Request!
The GitHub Discussions search collator fetches and indexes all discussions, including their comments and replies, for any specified repository, as long as the Backstage instance is configured with the appropriate GitHub integrations and has the necessary read access to the repository in question.
✔️ Checklist
Signed-off-byline in the message. (more info)