refactor(nexus-repository-manager): remove @janus-idp/cli and dynamic plugin build step #1843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… plugin build step Signed-off-by: Christoph Jerolimov <jerolimov+git@redhat.com>
christoph-jerolimov
requested review from
schultzp2020 and
a team
as code owners
Changed Packages
|
| headers: | ||
| X-Requested-With: 'XMLHttpRequest' | ||
| # Uncomment the following line to access a private Nexus Repository Manager using a token | ||
| # Authorization: 'Bearer <NEXUS_REPOSITORY_MANAGER_TOKEN>' |
There was a problem hiding this comment.
I renamed this from app-config.yaml to app-config.example.yaml because it contains no authorization by default.
| "config.d.ts", | ||
| "app-config.janus-idp.yaml" |
There was a problem hiding this comment.
This file didn't exist.
13 tasks
nickboldt
approved these changes
Nov 6, 2024
christoph-jerolimov
deleted the
remove-janus-idp-cli-from-nexus-repository-manager
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I just made a Pull Request!
This PR removes the
@janus-idp/clidependency andexport-dynamicscript from the 3scale workspace.Part of
✔️ Checklist
Signed-off-byline in the message. (more info)