Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jenkins): Add title property to Jenkins components #1940

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

megatroom
Copy link

Hey, I just made a Pull Request!

  • Add title prop to EntityJenkinsContent component;
  • Add title prop to EntityLatestJenkinsRunCard component;
  • Add missing test file for CITable component;

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

Signed-off-by: Bruno Nardini <megatroom3@gmail.com>
Signed-off-by: Bruno Nardini <megatroom3@gmail.com>
@megatroom megatroom requested a review from a team as a code owner November 15, 2024 13:08
@backstage-goalie
Copy link
Contributor

Changed Packages

Package Name Package Path Changeset Bump Current Version
@backstage-community/plugin-jenkins workspaces/jenkins/plugins/jenkins minor v0.11.1

Copy link
Contributor

@awanlin awanlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @megatroom, this looks good but we need to get the CI green. Looks like the API Reports need to be updated, here's details on how to do that: https://github.com/backstage/community-plugins/blob/main/CONTRIBUTING.md#api-reports

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants