Skip to content

Conversation

perf2711
Copy link
Contributor

When two session file markers have the same ID, but different timestamp, it results in an endless loop.

This change prevents that by also using the timestamp as session ID.

This requires changes in Electron.

@perf2711 perf2711 requested a review from konraddysput June 27, 2025 11:20
@perf2711 perf2711 self-assigned this Jun 27, 2025
@perf2711 perf2711 added the bug Something isn't working label Jun 27, 2025
Copy link
Collaborator

@konraddysput konraddysput left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If someone already has session files - where do you handle a conversion from the old data model to the new one?

interface FileSession {
readonly file: string;
readonly sessionId: string;
readonly sessionId: SessionId;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about backward compatibility?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, this could fail. I added a check for this where required.

@perf2711
Copy link
Contributor Author

where do you handle a conversion from the old data model to the new one?

There's no conversion, the session ID is not used then, because it is not complete.

@perf2711 perf2711 force-pushed the bugfix/session-id-timestamp branch from 8036415 to 1117d37 Compare July 1, 2025 09:58
@perf2711 perf2711 merged commit a7eb2c9 into main Jul 2, 2025
5 checks passed
@perf2711 perf2711 deleted the bugfix/session-id-timestamp branch July 2, 2025 13:11
This was referenced Jul 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants