Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move event reason/action strings to api/v1alpha1 pkg #771

Merged
merged 1 commit into from
Jun 20, 2023
Merged

move event reason/action strings to api/v1alpha1 pkg #771

merged 1 commit into from
Jun 20, 2023

Conversation

tesshuflower
Copy link
Contributor

Fixes: #767

Describe what this PR does

Is there anything that requires special attention?

Related issues:

@tesshuflower
move event reason/action strings to api/v1alpha1 pkg
8f38a50 
Fixes: backube#767

Signed-off-by: Tesshu Flower <tflower@redhat.com>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tesshuflower

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sonarcloud
Copy link

sonarcloud bot commented Jun 19, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
24.0% 24.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@JohnStrunk
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jun 20, 2023
@JohnStrunk
Copy link
Member

/override "SonarCloud Code Analysis"

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 20, 2023

@JohnStrunk: Overrode contexts on behalf of JohnStrunk: SonarCloud Code Analysis

In response to this:

/override "SonarCloud Code Analysis"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JohnStrunk
Copy link
Member

/retest

1 similar comment
@JohnStrunk
Copy link
Member

/retest

@openshift-merge-robot openshift-merge-robot merged commit 0c3cd25 into backube:main Jun 20, 2023
@tesshuflower tesshuflower deleted the evts_in_api_pkg branch June 20, 2023 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@JohnStrunk JohnStrunk

Labels
approved lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move event reason strings for replicationsource/destination to api/v1alpha1 package
3 participants
@tesshuflower @JohnStrunk @openshift-merge-robot