Try to address volumepopulator test flake

[tesshuflower]

• updates to error out in Eventually() if we do get a flake to help debug if the issue still happens intermittently.

Describe what this PR does

Try to address test flake that's occurred a couple times:

  [FAILED] Timed out after 60.001s.
  Expected
      <bool>: false
  to be true
  In [JustBeforeEach] at: /home/runner/work/volsync/volsync/controllers/volumepopulator_controller_test.go:688 @ 06/19/23 18:54:52.177
------------------------------
•••••••••••••••••••••••••••••••••••••••••••••••

Summarizing 1 Failure:
  [FAIL] VolumePopulator When a PVC is created that has a dataSourceRef with replicationdestination and a storageClassName When a storageclassname is specified in the pvc spec When the storageClass exists and latestImage snap is set on the RD [JustBeforeEach] When pvcPrime gets a PV bound When pvcPrime loses claim (bind controller rebinds the PV to pvc from pvcPrime) When snapshot has do-not-delete label Should cleanup pvcPrime (and volumesnapshot if necessary)
  /home/runner/work/volsync/volsync/controllers/volumepopulator_controller_test.go:688

Is there anything that requires special attention?

Related issues:

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tesshuflower

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [tesshuflower]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov]

Codecov Report

Merging #778 (c576c54) into main (ec4bcc2) will increase coverage by 0.0%.
The diff coverage is n/a.

Additional details and impacted files

@@          Coverage Diff          @@
##            main    #778   +/-   ##
=====================================
  Coverage   66.8%   66.9%           
=====================================
  Files         55      55           
  Lines       7054    7055    +1     
=====================================
+ Hits        4719    4726    +7     
+ Misses      2056    2052    -4     
+ Partials     279     277    -2     

see 1 file with indirect coverage changes

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[tesshuflower]

/retest

[tesshuflower]

/retest

[tesshuflower]

/retest

[openshift-ci]

@tesshuflower: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/ci-index-volsync-bundle	c576c54	link	true	/test ci-index-volsync-bundle

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[tesshuflower]

/retest

[tesshuflower]

/cc @JohnStrunk

[JohnStrunk]

/lgtm