Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fips fixes #789

Merged
merged 2 commits into from
Jul 5, 2023
Merged

Fips fixes #789

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f5bdd2e
restrict metrics to TLS1.2
tesshuflower Jul 5, 2023
6b02591
use CGO_ENABLED=1
tesshuflower Jul 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ WORKDIR /workspace
# We don't vendor modules. Enforce that behavior
ENV GOFLAGS=-mod=readonly
ENV GO111MODULE=on
ENV CGO_ENABLED=0
ENV CGO_ENABLED=1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at where the CGO_ENABLED=0 came in, I think it may be needed for the multi-arch builds (that we don't use)

ARG TARGETOS
ARG TARGETARCH
ENV GOOS=${TARGETOS:-linux}
Expand Down Expand Up @@ -58,7 +58,7 @@ COPY /mover-restic/minio-go ./minio-go

WORKDIR /workspace/restic

RUN go run build.go
RUN go run build.go --enable-cgo


######################################################################
Expand Down
4 changes: 2 additions & 2 deletions bundle/manifests/volsync.clusterserviceversion.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ metadata:
}
]
capabilities: Basic Install
createdAt: "2023-05-25T16:05:05Z"
createdAt: "2023-07-05T00:31:53Z"
olm.skipRange: '>=0.4.0 <0.8.0'
operators.operatorframework.io/builder: operator-sdk-v1.26.0
operators.operatorframework.io/project_layout: go.kubebuilder.io/v3
Expand Down Expand Up @@ -465,7 +465,7 @@ spec:
- --secure-listen-address=0.0.0.0:8443
- --upstream=http://127.0.0.1:8080/
- --logtostderr=true
- --tls-min-version=VersionTLS13
- --tls-min-version=VersionTLS12
- --v=0
image: quay.io/brancz/kube-rbac-proxy:v0.14.0
name: kube-rbac-proxy
Expand Down
2 changes: 1 addition & 1 deletion config/default/manager_auth_proxy_patch.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ spec:
- "--secure-listen-address=0.0.0.0:8443"
- "--upstream=http://127.0.0.1:8080/"
- "--logtostderr=true"
- "--tls-min-version=VersionTLS13"
- "--tls-min-version=VersionTLS12"
- "--v=0"
ports:
- containerPort: 8443
Expand Down
2 changes: 1 addition & 1 deletion helm/volsync/templates/deployment-controller.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ spec:
- --secure-listen-address=0.0.0.0:8443
- --upstream=http://127.0.0.1:8080/
- --logtostderr=true
- "--tls-min-version=VersionTLS13"
- "--tls-min-version=VersionTLS12"
- --v=0
{{- if .Values.metrics.disableAuth }}
- --ignore-paths=/metrics
Expand Down