restic: Make explicit sync only happen after restore #796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John Strunk <jstrunk@redhat.com>
|
/cc @tesshuflower |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnStrunk, tesshuflower The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does
This moves the
synccall at the end of the restic mover script so that it only happens after restore operations.Is there anything that requires special attention?
The sync exists to ensure data is flushed prior to creating a Snapshot. It is needed because we have no guarantee of sequencing between the node's
unmountand the CSI snapshot operation that is triggered by our creation of the Snapshot object. Since the snapshot would only affect the destination volume (restore), it is only applicable there.The unmount of volumes will cause their data to eventually get flushed, so when we don't care about sequencing, we don't need the explicit sync.
Related issues:
Fixes #788
Related #792