Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add .editorconfig #803

Closed
wants to merge 1 commit into from
Closed

chore: add .editorconfig #803

wants to merge 1 commit into from

Conversation

onedr0p
Copy link
Contributor

@onedr0p onedr0p commented Jul 15, 2023

Describe what this PR does

Most editors support this file and it's a good way that enforces some basic styling for contributors.

Most editors support this file and it's a good way that enforces some styling for contributors.

Signed-off-by: Devin Buhl <onedr0p@users.noreply.github.com>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 15, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: onedr0p
Once this PR has been reviewed and has the lgtm label, please assign birsanv for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 15, 2023

Hi @onedr0p. Thanks for your PR.

I'm waiting for a backube member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the size/S label Jul 15, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jul 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 30 days if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the Stale label Sep 14, 2023
@onedr0p
Copy link
Contributor Author

onedr0p commented Sep 14, 2023

Not stale

@github-actions github-actions bot removed the Stale label Sep 15, 2023
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 30 days if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the Stale label Nov 15, 2023
@onedr0p
Copy link
Contributor Author

onedr0p commented Nov 15, 2023

Not stale, this would be a great QoL change.

@github-actions github-actions bot removed the Stale label Nov 16, 2023
@onedr0p onedr0p closed this Dec 18, 2023
@onedr0p onedr0p deleted the patch-1 branch December 18, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant