Cleans up the files a bit

badgeteam · Jul 2, 2023 · 8018491 · 8018491
1 parent 84d7c28
commit 8018491
Show file tree

Hide file tree

Showing 3 changed files with 68 additions and 65 deletions.
diff --git a/.clang-tidy b/.clang-tidy
@@ -4,69 +4,72 @@ WarningsAsErrors: ''
 HeaderFilterRegex: ''
 AnalyzeTemporaryDtors: false
 CheckOptions:
-    'readability-identifier-naming.StructCase': 'lower_case'
-    'readability-identifier-naming.MemberCase': 'lower_case'
-    'readability-identifier-naming.ConstantCase': 'lower_case'
-    'readability-identifier-naming.ConstantParameterCase': 'lower_case'
-    'readability-identifier-naming.ConstantPointerParameterCase': 'lower_case'
-    'readability-identifier-naming.EnumCase': 'lower_case'
-    'readability-identifier-naming.EnumConstantCase': 'UPPER_CASE'
-    'readability-identifier-naming.FunctionCase': 'lower_case'
-    'readability-identifier-naming.GlobalConstantCase': 'lower_case'
-    'readability-identifier-naming.GlobalConstantPointerCase': 'lower_case'
-    'readability-identifier-naming.GlobalFunctionCase': 'lower_case'
-    'readability-identifier-naming.GlobalPointerCase': 'lower_case'
-    'readability-identifier-naming.GlobalVariableCase': 'lower_case'
-    'readability-identifier-naming.LocalConstantCase': 'lower_case'
-    'readability-identifier-naming.LocalConstantPointerCase': 'lower_case'
-    'readability-identifier-naming.FunctionCase': 'lower_case'
-    'readability-identifier-naming.LocalPointerCase': 'lower_case'
-    'readability-identifier-naming.LocalVariableCase': 'lower_case'
-
-    # readability-identifier-naming.MacroDefinitionCase: ['lower_case','UPPER_CASE'] # We cannot use that as we have variable macro casing
-    'readability-identifier-naming.ParameterCase': 'lower_case'
-    'readability-identifier-naming.ParameterPackCase': 'lower_case'
-    'readability-identifier-naming.PointerParameterCase': 'lower_case'
-    'readability-identifier-naming.StaticConstantCase': 'lower_case'
-    'readability-identifier-naming.StaticVariableCase': 'lower_case'
-    'readability-identifier-naming.TypeAliasCase': 'lower_case'
-    'readability-identifier-naming.TypedefCase': 'lower_case'
-    'readability-identifier-naming.TypedefIgnoredRegexp': 'va_list' # regex of accepted violations
-    'readability-identifier-naming.FunctionCase': 'lower_case'
-    'readability-identifier-naming.UnionCase': 'lower_case'
-    'readability-identifier-naming.VariableCase': 'lower_case'
-
-    # Types have no prefix:
-    'readability-identifier-naming.StructPrefix': ''
-    'readability-identifier-naming.UnionPrefix': ''
-    'readability-identifier-naming.EnumPrefix': ''
-    'readability-identifier-naming.TypedefPrefix': ''
-
-    # Types have an '_t' suffix:
-    'readability-identifier-naming.StructSuffix': '_t'
-    'readability-identifier-naming.UnionSuffix': '_t'
-    'readability-identifier-naming.EnumSuffix': '_t'
-    'readability-identifier-naming.TypedefSuffix': '_t'
+  # naming 
+  readability-identifier-naming.StructCase: 'lower_case'
+  readability-identifier-naming.MemberCase: 'lower_case'
+  readability-identifier-naming.ConstantCase: 'lower_case'
+  readability-identifier-naming.ConstantParameterCase: 'lower_case'
+  readability-identifier-naming.ConstantPointerParameterCase: 'lower_case'
+  readability-identifier-naming.EnumCase: 'lower_case'
+  readability-identifier-naming.EnumConstantCase: 'UPPER_CASE'
+  readability-identifier-naming.FunctionCase: 'lower_case'
+  readability-identifier-naming.GlobalConstantCase: 'lower_case'
+  readability-identifier-naming.GlobalConstantPointerCase: 'lower_case'
+  readability-identifier-naming.GlobalFunctionCase: 'lower_case'
+  readability-identifier-naming.GlobalPointerCase: 'lower_case'
+  readability-identifier-naming.GlobalVariableCase: 'lower_case'
+  readability-identifier-naming.LocalConstantCase: 'lower_case'
+  readability-identifier-naming.LocalConstantPointerCase: 'lower_case'
+  readability-identifier-naming.FunctionCase: 'lower_case'
+  readability-identifier-naming.LocalPointerCase: 'lower_case'
+  readability-identifier-naming.LocalVariableCase: 'lower_case'
 
-    # defined by default
-    llvm-else-after-return.WarnOnConditionVariables: 'false'
-    modernize-loop-convert.MinConfidence: reasonable
-    modernize-replace-auto-ptr.IncludeStyle: llvm
-    cert-str34-c.DiagnoseSignedUnsignedCharComparisons: 'false'
-    google-readability-namespace-comments.ShortNamespaceLines: '10'
-    cert-err33-c.CheckedFunctions: '::aligned_alloc;::asctime_s;::at_quick_exit;::atexit;::bsearch;::bsearch_s;::btowc;::c16rtomb;::c32rtomb;::calloc;::clock;::cnd_broadcast;::cnd_init;::cnd_signal;::cnd_timedwait;::cnd_wait;::ctime_s;::fclose;::fflush;::fgetc;::fgetpos;::fgets;::fgetwc;::fopen;::fopen_s;::fprintf;::fprintf_s;::fputc;::fputs;::fputwc;::fputws;::fread;::freopen;::freopen_s;::fscanf;::fscanf_s;::fseek;::fsetpos;::ftell;::fwprintf;::fwprintf_s;::fwrite;::fwscanf;::fwscanf_s;::getc;::getchar;::getenv;::getenv_s;::gets_s;::getwc;::getwchar;::gmtime;::gmtime_s;::localtime;::localtime_s;::malloc;::mbrtoc16;::mbrtoc32;::mbsrtowcs;::mbsrtowcs_s;::mbstowcs;::mbstowcs_s;::memchr;::mktime;::mtx_init;::mtx_lock;::mtx_timedlock;::mtx_trylock;::mtx_unlock;::printf_s;::putc;::putwc;::raise;::realloc;::remove;::rename;::scanf;::scanf_s;::setlocale;::setvbuf;::signal;::snprintf;::snprintf_s;::sprintf;::sprintf_s;::sscanf;::sscanf_s;::strchr;::strerror_s;::strftime;::strpbrk;::strrchr;::strstr;::strtod;::strtof;::strtoimax;::strtok;::strtok_s;::strtol;::strtold;::strtoll;::strtoul;::strtoull;::strtoumax;::strxfrm;::swprintf;::swprintf_s;::swscanf;::swscanf_s;::thrd_create;::thrd_detach;::thrd_join;::thrd_sleep;::time;::timespec_get;::tmpfile;::tmpfile_s;::tmpnam;::tmpnam_s;::tss_create;::tss_get;::tss_set;::ungetc;::ungetwc;::vfprintf;::vfprintf_s;::vfscanf;::vfscanf_s;::vfwprintf;::vfwprintf_s;::vfwscanf;::vfwscanf_s;::vprintf_s;::vscanf;::vscanf_s;::vsnprintf;::vsnprintf_s;::vsprintf;::vsprintf_s;::vsscanf;::vsscanf_s;::vswprintf;::vswprintf_s;::vswscanf;::vswscanf_s;::vwprintf_s;::vwscanf;::vwscanf_s;::wcrtomb;::wcschr;::wcsftime;::wcspbrk;::wcsrchr;::wcsrtombs;::wcsrtombs_s;::wcsstr;::wcstod;::wcstof;::wcstoimax;::wcstok;::wcstok_s;::wcstol;::wcstold;::wcstoll;::wcstombs;::wcstombs_s;::wcstoul;::wcstoull;::wcstoumax;::wcsxfrm;::wctob;::wctrans;::wctype;::wmemchr;::wprintf_s;::wscanf;::wscanf_s;'
-    cert-oop54-cpp.WarnOnlyIfThisHasSuspiciousField: 'false'
-    cert-dcl16-c.NewSuffixes: 'L;LL;LU;LLU'
-    google-readability-braces-around-statements.ShortStatementLines: '1'
-    cppcoreguidelines-non-private-member-variables-in-classes.IgnoreClassesWithAllMemberVariablesBeingPublic: 'true'
-    google-readability-namespace-comments.SpacesBeforeComments: '2'
-    modernize-loop-convert.MaxCopySize: '16'
-    modernize-pass-by-value.IncludeStyle: llvm
-    modernize-use-nullptr.NullMacros: 'NULL'
-    llvm-qualified-auto.AddConstToQualified: 'false'
-    modernize-loop-convert.NamingStyle: CamelCase
-    llvm-else-after-return.WarnOnUnfixable: 'false'
-    google-readability-function-size.StatementThreshold: '800'
+  # readability-identifier-naming.MacroDefinitionCase: ['lower_case','UPPER_CASE'] # We cannot use that as we have variable macro casing
+  readability-identifier-naming.ParameterCase: 'lower_case'
+  readability-identifier-naming.ParameterPackCase: 'lower_case'
+  readability-identifier-naming.PointerParameterCase: 'lower_case'
+  readability-identifier-naming.StaticConstantCase: 'lower_case'
+  readability-identifier-naming.StaticVariableCase: 'lower_case'
+  readability-identifier-naming.TypeAliasCase: 'lower_case'
+  readability-identifier-naming.TypedefCase: 'lower_case'
+  readability-identifier-naming.TypedefIgnoredRegexp: 'va_list' # regex of accepted violations
+  readability-identifier-naming.FunctionCase: 'lower_case'
+  readability-identifier-naming.UnionCase: 'lower_case'
+  readability-identifier-naming.VariableCase: 'lower_case'
+
+  # Types have no prefix:
+  readability-identifier-naming.StructPrefix: ''
+  readability-identifier-naming.UnionPrefix: ''
+  readability-identifier-naming.EnumPrefix: ''
+  readability-identifier-naming.TypedefPrefix: ''
+
+  # Types have an '_t' suffix:
+  readability-identifier-naming.StructSuffix: '_t'
+  readability-identifier-naming.UnionSuffix: '_t'
+  readability-identifier-naming.EnumSuffix: '_t'
+  readability-identifier-naming.TypedefSuffix: '_t'
+
+
+
+  # defined by default
+  llvm-else-after-return.WarnOnConditionVariables: 'false'
+  modernize-loop-convert.MinConfidence: reasonable
+  modernize-replace-auto-ptr.IncludeStyle: llvm
+  cert-str34-c.DiagnoseSignedUnsignedCharComparisons: 'false'
+  google-readability-namespace-comments.ShortNamespaceLines: '10'
+  cert-err33-c.CheckedFunctions: '::aligned_alloc;::asctime_s;::at_quick_exit;::atexit;::bsearch;::bsearch_s;::btowc;::c16rtomb;::c32rtomb;::calloc;::clock;::cnd_broadcast;::cnd_init;::cnd_signal;::cnd_timedwait;::cnd_wait;::ctime_s;::fclose;::fflush;::fgetc;::fgetpos;::fgets;::fgetwc;::fopen;::fopen_s;::fprintf;::fprintf_s;::fputc;::fputs;::fputwc;::fputws;::fread;::freopen;::freopen_s;::fscanf;::fscanf_s;::fseek;::fsetpos;::ftell;::fwprintf;::fwprintf_s;::fwrite;::fwscanf;::fwscanf_s;::getc;::getchar;::getenv;::getenv_s;::gets_s;::getwc;::getwchar;::gmtime;::gmtime_s;::localtime;::localtime_s;::malloc;::mbrtoc16;::mbrtoc32;::mbsrtowcs;::mbsrtowcs_s;::mbstowcs;::mbstowcs_s;::memchr;::mktime;::mtx_init;::mtx_lock;::mtx_timedlock;::mtx_trylock;::mtx_unlock;::printf_s;::putc;::putwc;::raise;::realloc;::remove;::rename;::scanf;::scanf_s;::setlocale;::setvbuf;::signal;::snprintf;::snprintf_s;::sprintf;::sprintf_s;::sscanf;::sscanf_s;::strchr;::strerror_s;::strftime;::strpbrk;::strrchr;::strstr;::strtod;::strtof;::strtoimax;::strtok;::strtok_s;::strtol;::strtold;::strtoll;::strtoul;::strtoull;::strtoumax;::strxfrm;::swprintf;::swprintf_s;::swscanf;::swscanf_s;::thrd_create;::thrd_detach;::thrd_join;::thrd_sleep;::time;::timespec_get;::tmpfile;::tmpfile_s;::tmpnam;::tmpnam_s;::tss_create;::tss_get;::tss_set;::ungetc;::ungetwc;::vfprintf;::vfprintf_s;::vfscanf;::vfscanf_s;::vfwprintf;::vfwprintf_s;::vfwscanf;::vfwscanf_s;::vprintf_s;::vscanf;::vscanf_s;::vsnprintf;::vsnprintf_s;::vsprintf;::vsprintf_s;::vsscanf;::vsscanf_s;::vswprintf;::vswprintf_s;::vswscanf;::vswscanf_s;::vwprintf_s;::vwscanf;::vwscanf_s;::wcrtomb;::wcschr;::wcsftime;::wcspbrk;::wcsrchr;::wcsrtombs;::wcsrtombs_s;::wcsstr;::wcstod;::wcstof;::wcstoimax;::wcstok;::wcstok_s;::wcstol;::wcstold;::wcstoll;::wcstombs;::wcstombs_s;::wcstoul;::wcstoull;::wcstoumax;::wcsxfrm;::wctob;::wctrans;::wctype;::wmemchr;::wprintf_s;::wscanf;::wscanf_s;'
+  cert-oop54-cpp.WarnOnlyIfThisHasSuspiciousField: 'false'
+  cert-dcl16-c.NewSuffixes: 'L;LL;LU;LLU'
+  google-readability-braces-around-statements.ShortStatementLines: '1'
+  cppcoreguidelines-non-private-member-variables-in-classes.IgnoreClassesWithAllMemberVariablesBeingPublic: 'true'
+  google-readability-namespace-comments.SpacesBeforeComments: '2'
+  modernize-loop-convert.MaxCopySize: '16'
+  modernize-pass-by-value.IncludeStyle: llvm
+  modernize-use-nullptr.NullMacros: 'NULL'
+  llvm-qualified-auto.AddConstToQualified: 'false'
+  modernize-loop-convert.NamingStyle: CamelCase
+  llvm-else-after-return.WarnOnUnfixable: 'false'
+  google-readability-function-size.StatementThreshold: '800'
 
 
 #  lower_case,

diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml
@@ -4,7 +4,7 @@ on:
   push:
     branches: ['main']
   pull_request:
-    branches: ['main', 'format_tooling']
+    branches: ['main']
 
 env:
   CMAKE_GENERATOR: Ninja

diff --git a/.github/workflows/guidelines.yaml b/.github/workflows/guidelines.yaml
@@ -4,7 +4,7 @@ on:
   push:
     branches: ['main']
   pull_request:
-    branches: ['main', 'format_tooling']
+    branches: ['main']
 
 jobs:
   validate-format:
@@ -50,5 +50,5 @@ jobs:
         run: |
           echo "scan the following files:"
           jq -r '.[].file' build/compile_commands.json | grep '\.[ch]$'
-          clang-tidy-16 --version
+          echo "analysis results:"
           clang-tidy-16 -p build $(jq -r '.[].file' build/compile_commands.json | grep '\.[ch]$') --warnings-as-errors="*"